FW-262: Fix GHA #33
Merged
FW-262: Fix GHA #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astley92
requested review from
zubin,
chrisixion,
aathithya-zepto and
a team
and removed request for
a team
zubin
approved these changes
Feb 27, 2024
| @@ -3,9 +3,13 @@ name: Update bank/branch data | |||
| on: | |||
| schedule: | |||
| - cron: "0 1 * * *" # 1am UTC | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Does this need to be present? Seems unusual to have an empty object.
There was a problem hiding this comment.
Just added this to allow us to trigger it manually through the github UI. Will help me test that this works too. From some examples I've seen this is how to enable this trigger when there are others. Will triple but happy to remove after we've tested if we'd prefer 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our default permissions are no longer permissive enough to allow PR's to be created so defining them explicitly.
Also allowing the workflow to be run manually and bumping some action versions