doc: posix: update for POSIX_FILE_SYSTEM_R
#81475
Conversation
zephyrbot
added
Release Notes
zephyrbot
requested review from
cfriedt,
dkalowsk,
kartben and
mmahadevan108
Add section for POSIX_FILE_SYSTEM_R which contains only `readdir_r()`. Signed-off-by: Yong Cong Sin <[email protected]>
Mention the `_POSIX_THREAD_SAFE_FUNCTIONS` functions implemented in zephyrproject-rtos#74394. Signed-off-by: Yong Cong Sin <[email protected]>
ycsin
force-pushed
the
pr/posix-readdir_r
branch
from
afe04b6
to
eacdd8f
Compare
|
Ya unfortunately it's too late. You may maybe submit a PR against the branch but I never remember if it's something we do or if submissions have to be handled as backports |
| @@ -1381,6 +1382,7 @@ Libraries / Subsystems | |||
| * :ref:`_POSIX_THREAD_SAFE_FUNCTIONS <posix_option_thread_safe_functions>` improvements: | |||
|
|
|||
| * Support for :c:func:`asctime_r`, :c:func:`ctime_r`, and :c:func:`localtime_r`. | |||
| * Added stub for :c:func:`getpwnam_r`, :c:func:`getpwuid_r`, :c:func:`getgrgid_r` and :c:func:`getgrnam_r`. | |||
There was a problem hiding this comment.
I think this is maybe Ok for a backport PR to v4.0.
However, looking into things a bit deeper, getpwnam_r(), getpwuid_r(), getgrgid_r(), and getgrnam_r() belong to a separate Option Group -
POSIX_SYSTEM_DATABASE_R. And the non-reentrant versions of these belong to the POSIX_SYSTEM_DATABASE Option Group, and _POSIX_THREAD_SAFE_FUNCTIONS is more of an Option / Feature Test Macro.
So really what we need here is a new Kconfig.system_database file with two new Kconfig options (same as the option group names).
_POSIX_THREAD_SAFE_FUNCTIONS should probably be a hidden Kconfig option that depends on other Kconfig values being enabled. Namely, CONFIG_POSIX_SYSTEM_DATABASE_R, CONFIG_POSIX_C_LANG_SUPPORT_R, CONFIG_POSIX_FILE_LOCKING, CONFIG_POSIX_FILE_SYSTEM_R.
And then of course modify the docs
https://pubs.opengroup.org/onlinepubs/9799919799/xrat/V4_subprofiles.html
There was a problem hiding this comment.
All of the above should be in a separate PR.
|
Very much missed the release. Happy to add to the 4.0.1 backport list though! |
Update the notes for
POSIX_FILE_SYSTEM_R, looks like I missed the v4 release