driver: adc: kconfig #81467
Open
driver: adc: kconfig #81467
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: NXP
zephyrbot
requested review from
anangl,
butok,
danieldegrasse,
dbaluta,
decsny,
DerekSnell,
EmilioCBen,
manuargue,
MarkWangChinese and
yvanderv
Raymond0225
force-pushed
the
add_adc_etc_rt11xx
branch
from
49d082e
to
cdc916c
Compare
On NXP RT1170 SOC, ADC ETC exists but it can not be enabled because of dependency on HAS_MCUX_ADC_ETC. Also, ADC ETC should only work with ADC together, there is no use case to run it standalone. Fixes:zephyrproject-rtos#81466 Signed-off-by: Raymond Lei <[email protected]>
Raymond0225
force-pushed
the
add_adc_etc_rt11xx
branch
from
cdc916c
to
0618c63
Compare
| @@ -40,6 +40,7 @@ config ADC_MCUX_LPADC | |||
| config ADC_MCUX_ETC | |||
| bool "MCUX ADC ETC driver" | |||
| depends on HAS_MCUX_ADC_ETC | |||
| depends on ADC_MCUX_LPADC | |||
There was a problem hiding this comment.
Why would this depend on the LPADC? Parts like the RT1064 which do not have an LPADC have the ADC_ETC IP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On NXP RT1170 SOC, ADC ETC exists but it can not be enabled because of dependency on HAS_MCUX_ADC_ETC. The expectation is when CONFIG_ADC=y, ADC ETC should be enabled automatically if it exists. Fixes:#81466