Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: arm: irq: Add overlays files for Infineon boards #81464

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

npal-cy
Copy link
Contributor

@npal-cy npal-cy commented Nov 15, 2024

Infineon: board: Add CONFIG_GPIO to defconfigs

Add CONFIG_GPIO from defconfigs for Infineon boards.

Revert pull/81377, which affect some ble samples which
used GPIO.

Signed-off-by: Nazar Palamar [email protected]

test: arm: irq: Add overlays files for Infineon boards

Changed interrupt priority for GPIO, default 6 is not suitable for
for the ZERO_LATENCY_IRQS function used in this test.
used in this test.

FIX CI: https://github.com/zephyrproject-rtos/zephyr/actions/runs/11524969451/job/32695832470?pr=80025
Signed-off-by: Nazar Palamar [email protected]

Add CONFIG_GPIO from defconfigs for Infineon boards.

Revert pull/81377, which affect some ble samples which
used GPIO.

Signed-off-by: Nazar Palamar <[email protected]>
Changed interrupt priority for GPIO, default 6 is not suitable for
for the ZERO_LATENCY_IRQS function used in this test.
used in this test.

Signed-off-by: Nazar Palamar <[email protected]>
@ifyall ifyall added this to the v4.0.0 milestone Nov 15, 2024
@mmahadevan108
Copy link
Collaborator

I had expressed my concerns about deleting GPIO from the defconfig #81377 (comment)
However you had mentioned that change was needed for the zero latency use-case.
Can you please explain what you are changing here?

Copy link
Collaborator

@thedjnK thedjnK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was literally removed not even 1 day ago 7e1b00d why was this removed only to be re-added?

@npal-cy
Copy link
Contributor Author

npal-cy commented Nov 15, 2024

I had expressed my concerns about deleting GPIO from the defconfig #81377 (comment)
However you had mentioned that change was needed for the zero latency use-case.
Can you please explain what you are changing here?

Yes this changes was fixed zero latency use-case, but i found it affected some sample(#81435). So before 4.0 release it safe to fix locally only zero latency by adding overlay files rather then add overlays to a lot set of samples...(see my closed PR #81435)

@npal-cy
Copy link
Contributor Author

npal-cy commented Nov 15, 2024

This was literally removed not even 1 day ago 7e1b00d why was this removed only to be re-added?

see my comment above.

@npal-cy npal-cy requested a review from thedjnK November 15, 2024 22:38
@dkalowsk dkalowsk added the backport v4.0-branch Backport to the v4.0-branch label Nov 15, 2024
@dkalowsk dkalowsk modified the milestones: v4.0.0, v4.1.0 Nov 15, 2024
@dkalowsk
Copy link
Contributor

Looking at this right now we are marking this for backport to 4.0.1. We're not comfortable dismissing the change request comment here based upon the answer provided.

@thedjnK
Copy link
Collaborator

thedjnK commented Nov 16, 2024

Revert pull/81377, which affect some ble samples which used GPIO.

If a sample needs GPIO then the sample should enable it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ARM ARM (32-bit) Architecture backport v4.0-branch Backport to the v4.0-branch platform: Infineon Infineon Technologies AG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants