-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: arm: irq: Add overlays files for Infineon boards #81464
base: main
Are you sure you want to change the base?
test: arm: irq: Add overlays files for Infineon boards #81464
Conversation
Add CONFIG_GPIO from defconfigs for Infineon boards. Revert pull/81377, which affect some ble samples which used GPIO. Signed-off-by: Nazar Palamar <[email protected]>
Changed interrupt priority for GPIO, default 6 is not suitable for for the ZERO_LATENCY_IRQS function used in this test. used in this test. Signed-off-by: Nazar Palamar <[email protected]>
I had expressed my concerns about deleting GPIO from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was literally removed not even 1 day ago 7e1b00d why was this removed only to be re-added?
Yes this changes was fixed zero latency use-case, but i found it affected some sample(#81435). So before 4.0 release it safe to fix locally only zero latency by adding overlay files rather then add overlays to a lot set of samples...(see my closed PR #81435) |
Looking at this right now we are marking this for backport to 4.0.1. We're not comfortable dismissing the change request comment here based upon the answer provided. |
If a sample needs GPIO then the sample should enable it |
Infineon: board: Add CONFIG_GPIO to defconfigs
Add CONFIG_GPIO from defconfigs for Infineon boards.
Revert pull/81377, which affect some ble samples which
used GPIO.
Signed-off-by: Nazar Palamar [email protected]
test: arm: irq: Add overlays files for Infineon boards
Changed interrupt priority for GPIO, default 6 is not suitable for
for the ZERO_LATENCY_IRQS function used in this test.
used in this test.
FIX CI: https://github.com/zephyrproject-rtos/zephyr/actions/runs/11524969451/job/32695832470?pr=80025
Signed-off-by: Nazar Palamar [email protected]