tests: posix: common: separate posix c_lib_ext to standalone test #81441
+96
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pancakem
force-pushed
the
separate_posix_c_lib_ext_into_standalone_test
branch
from
b2e9176
to
c0122d7
Compare
cfriedt
requested changes
Nov 15, 2024
There was a problem hiding this comment.
Please also move the getentropy and getopt tests to the new directory in this PR as well.
Note: getentropy() was added as part of the 2024 revision but was not part of the 2008 revision.
https://pubs.opengroup.org/onlinepubs/9799919799/xrat/V4_subprofiles.html
Pancakem
force-pushed
the
separate_posix_c_lib_ext_into_standalone_test
branch
from
c0122d7
to
232585b
Compare
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves fnmatch, getopt and getentropy into a singular testsuite at tests/posix/c_lib_ext app directory. Signed-off-by: Marvin Ouma <[email protected]>
Pancakem
force-pushed
the
separate_posix_c_lib_ext_into_standalone_test
branch
from
232585b
to
dd22cbc
Compare
cfriedt
reviewed
Nov 15, 2024
| CONFIG_POSIX_API=y | ||
| CONFIG_ZTEST=y | ||
|
|
||
| CONFIG_POSIX_AEP_CHOICE_BASE=y |
There was a problem hiding this comment.
I'm still kind of hesitant about having this here just because CONFIG_POSIX_C_LIB_EXT probably should not depend on any other POSIX options.
Will the test still pass if this line is removed?
Suggested change
| CONFIG_POSIX_AEP_CHOICE_BASE=y |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79454
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves fnmatch into a singular testsuite at tests/posix/c_lib_ext app directory.