-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LE Audio: Use depends on
instead of select
#81328
Draft
Thalley
wants to merge
9
commits into
zephyrproject-rtos:main
Choose a base branch
from
Thalley:bap_kconfig_updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
changed the title
Bap kconfig updates
LE Audio: Use Nov 13, 2024
depends on
instead of select
Thalley
force-pushed
the
bap_kconfig_updates
branch
6 times, most recently
from
November 14, 2024 19:17
a912723
to
6ab2700
Compare
Remove the selects from BT_BAP_UNICAST_SERVER and BT_BAP_UNICAST_CLIENT and use a def_bool for BT_BAP_UNICAST. This is part of an effort to reduce select in Kconfig. Signed-off-by: Emil Gydesen <[email protected]>
Modify the Kconfig options to depend on the GATT features rather than selecting them. This is part of an effort to reduce the amount of selects we use in LE Audio. Signed-off-by: Emil Gydesen <[email protected]>
Remove the selects and use def_bool for BT_AUDIO_RX and BT_AUDIO_TX. This is part of an effort to reduce select in Kconfig. Signed-off-by: Emil Gydesen <[email protected]>
The BAP_BROADCAST_SOURCE Kconfig option now depends on BT_ISO_BROADCASTER instead of selecting it. This is an effort to reduce the use of select in LE Audio. Signed-off-by: Emil Gydesen <[email protected]>
The BAP Kconfigs option now depends on BT_ISO_BROADCASTER instead of selecting it. This is an effort to reduce the use of select in LE Audio. Signed-off-by: Emil Gydesen <[email protected]>
Modify ASCS and BAP Broadcast sink to depend on the PAC options instead of selecting them. Since Kconfig does not support "depends on X if Y", a select for PAC_{SRC,SNK} is used depending on ASCS_ASE_{SRC,SNK}. Signed-off-by: Emil Gydesen <[email protected]>
Change the select of BT_PER_ADV_SYNC and BT_EXT_ADV to depends on. This is an effort to reduce the use of select for Kconfig options. Signed-off-by: Emil Gydesen <[email protected]>
Change the select to a depends on for the Kconfig options for HAS and HAS_CLIENT. This is an effort to reduce the number of selects used by LE Audio. Signed-off-by: Emil Gydesen <[email protected]>
Add the list of affect Kconfig options to the migration guide. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_kconfig_updates
branch
from
November 15, 2024 13:30
6ab2700
to
7cba91e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #72559