doc: release: NXP contributions #81236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
from
09f8c44
to
56f60ee
Compare
mmahadevan108
requested review from
dleach02,
danieldegrasse,
decsny and
EmilioCBen
JarmouniA
suggested changes
Nov 11, 2024
decsny
previously requested changes
Nov 11, 2024
doc/releases/release-notes-4.0.rst
Outdated
| @@ -410,6 +551,8 @@ Drivers and Sensors | |||
|
|
|||
| * I3C | |||
|
|
|||
| * Moved clocking code out of the NXP I3C driver | |||
There was a problem hiding this comment.
not sure if this needs to go in the release notes as it isn't exposed to users, it's basically just a refactor of where some code was in the tree
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
3 times, most recently
from
394d15a
to
36ec187
Compare
|
@JarmouniA, @decsny, your change suggestions have been integrated. Thanks. |
kartben
previously requested changes
Nov 12, 2024
doc/releases/release-notes-4.0.rst
Outdated
| * Added two new build commands, ``make html-live`` and ``make html-live-fast``, that automatically locally | ||
| host the generated documentation. They also automatically rebuild and rehost the documentation when changes | ||
| to the input ``.rst`` files are detected on the filesystem. | ||
| * Improved the documentation of dt_chosen_has_compat as an argument was missing |
There was a problem hiding this comment.
definitely not something worth mentioning in release notes :) drop the entire change since you're also introducing a duplicated bullet item with "Added two new build ..."
doc/releases/release-notes-4.0.rst
Outdated
Comment on lines
1337
to
1499
| * Added documentation (readme) for the erase_blocks flash test | ||
| * Extended the tests of counter_basic_api with a testcase for counters wihtout alarms | ||
| * Excluded NXP RW612 based boards from the WiFi test suite, as these boards require binary blobs | ||
| be downloaded in order to build as expected | ||
| * Added support for testing SDMMC devices to the fatfs API test | ||
| * Extended net/vlan to add IPv6 prefix config to each vlan-iface | ||
| * Enhanced the camera fixture test by adding a color bar to enable automation | ||
| * Fixed floating point logging issue in the video driver sample code | ||
| * Added a number crunching (maths such as FFT, echo cancellation) sample using optimized an | ||
| library for the NXP ADSP board | ||
| * Tailored the SPI_LOOPBACK test to the limitations of NXP Kinetis MCU's | ||
| * Enabled the video sample to run video capture (samples/drivers/video) | ||
| * Add arguments to the twister runner for SoC, Platform and Simulation |
There was a problem hiding this comment.
as before, don't go to the level of details where you're describing changes or tweaks being made to tests (to put it differently: if the release notes are effectively going to the level of detail were it's one bullet point per PR or commit, then we'd rather point users directly to the GitHub interface to see what's new by themselves :) )
JarmouniA
suggested changes
Nov 12, 2024
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
from
36ec187
to
cbbf6b1
Compare
kartben
reviewed
Nov 12, 2024
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
2 times, most recently
from
ed9817a
to
9600a29
Compare
kartben
reviewed
Nov 13, 2024
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
from
9600a29
to
de48cf9
Compare
JarmouniA
suggested changes
Nov 13, 2024
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
from
de48cf9
to
ffe15d5
Compare
JarmouniA
suggested changes
Nov 14, 2024
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
from
ffe15d5
to
6b474c0
Compare
decsny
reviewed
Nov 14, 2024
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
from
6b474c0
to
77ec768
Compare
decsny
reviewed
Nov 15, 2024
decsny
reviewed
Nov 15, 2024
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
from
77ec768
to
26fd307
Compare
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
from
26fd307
to
9553e0b
Compare
Adding NXP's contributions to v4.0 Signed-off-by: Yves Vandervennet <[email protected]>
yvanderv
force-pushed
the
release-notes-v4.0.0-nxp-contributions
branch
from
9553e0b
to
5e7a691
Compare
|
@mmahadevan108 @danieldegrasse @kartben , please review. |
| @@ -384,6 +438,12 @@ Drivers and Sensors | |||
| * DAC | |||
|
|
|||
| * DAC API now supports specifying channel path as internal. Support has been added in STM32 drivers. | |||
| * Updated the NXP counter_mcux_lptmr driver to support multiple instances of the lptmr | |||
There was a problem hiding this comment.
Sorry I missed this- these look like they should be in the "Counter" section, not DAC
kartben
reviewed
Nov 15, 2024
| @@ -701,6 +794,9 @@ Drivers and Sensors | |||
| * Added Würth Elektronik HIDS-2525020210002 | |||
| :dtcompatible:`we,wsen-hids-2525020210002` humidity sensor driver. | |||
|
|
|||
| * Added general samples for triggers | |||
| * Added driver for NXP's fxls8974 accelerometer | |||
There was a problem hiding this comment.
this is already mentioned in the nxp section
| @@ -1373,9 +1498,22 @@ Tests and Samples | |||
| * Together with the deprecation of :ref:`native_posix<native_posix>`, many tests which were | |||
| explicitly run in native_posix now run in :ref:`native_sim<native_sim>` instead. | |||
| native_posix as a platform remains tested though. | |||
| * Added documentation (readme) for the erase_blocks flash test | |||
There was a problem hiding this comment.
this is really not that important
Comment on lines
+1502
to
+1504
| * Extended the tests of counter_basic_api with a testcase for counters wihtout alarms | ||
| * Excluded NXP RW612 based boards from the WiFi test suite, as these boards require binary blobs | ||
| be downloaded in order to build as expected |
There was a problem hiding this comment.
not something for release notes
| * Added support for testing SDMMC devices to the fatfs API test | ||
| * Extended net/vlan to add IPv6 prefix config to each vlan-iface | ||
| * Enhanced the camera fixture test by adding a color bar to enable automation | ||
| * Fixed floating point logging issue in the video driver sample code |
There was a problem hiding this comment.
sounds like a really minor change , not sure why this is mentioned?
|
I will be dismissing my review so that this can be approved by others if they feel this is good enough. |
mmahadevan108
approved these changes
Nov 15, 2024
dleach02
approved these changes
Nov 15, 2024
|
Mahesh is going to follow up with a PR to address the last comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding NXP's contributions to v4.0