tests: bsim: Bluetooth: Enable some high reliability CAP tests #80788
+944
−552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
from
9c535d8
to
913f41d
Compare
rruuaanng
added
area: Bluetooth
area: Tests
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
2 times, most recently
from
0e48d6e
to
d05a193
Compare
zephyrbot
added
area: Bluetooth Controller
area: Bluetooth Audio
platform: nRF BSIM
zephyrbot
requested review from
asbjornsabo,
carlescufi,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
kruithofa,
larsgk,
MariuszSkamra,
mtpr-ot,
niym-ot,
pin-zephyr,
sjanc,
Thalley and
thoh-ot
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
from
d05a193
to
58705a3
Compare
|
Failure log snippet in CI run that is different from local run: Local run PA Sync quicker: |
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
2 times, most recently
from
81c48ba
to
a706cf5
Compare
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
3 times, most recently
from
c133cd2
to
4950663
Compare
Thalley
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Since these test scripts are already taking a long time to finish given the many test cases in each of them, we should consider either running them in parallel in this script somehow, or split the files.
We could either split them like
AC_14_8 -> Run all 8_x_x tests
AC_14_16 -> Run all 16_x_x tests
AC_14_24 -> Run all 24_x_x tests
etc.
or split them by high and light reliability.
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
from
4950663
to
211084d
Compare
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
from
211084d
to
5522ef0
Compare
Fix to reschedule before overlap and be collision resolved in the next periodic interval for tickers using slot window yield. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Introduce ticker reschedule with drift so that role like AUX_ADV_IND can start after overlapping states and roles using time reservations. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Add implementation for Extended Advertising Auxiliary PDUs to use ticks slot window feature. This will allow the periodic scheduling of AUX_ADV_IND PDUs to drift upto 10 ms advertising delay minus the ticks_slot time reservation of the AUX_ADV_IND PDU when overlapping with other states/roles that cannot be moved around, to avoid skipping them. Having an active Extended Advertising simultaneously with an ISO Synchronized Receiver or Connected ISO connection will now have less ISO SDU loss when using 10 ms ISO intervals. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix ISO Sync Receiver implementation to correctly reflect the payload number and timestamp. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix ISO Sync Receiver time reservation calculation to use peer broadcasted bis_spacing and sub_interval, instead of incorrectly calculating using local implementation used tMSS value. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix ISO Sync Receiver implementation to correctly prevent subevent from pre-empted in the unreserve time space. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Several tests were using K_FOREVER when allocating the buffer for TX in the system workqueue, which is illegal behavior. The solution chosen was to create a TX thread to handle TX, similar to the solution used in the audio shell and some sample applications. This way we can continue to use K_FOREVER when allocting buffers and it will always be done in a round-robin fashion while TXing as much as possible, by always enqueuing all the buffers with mock data. Since this works for all streams (both broadcast and unicast), it was obvious to use the same implementation for all tests, and thus cleaning up the tests a bit and more them more similar. Signed-off-by: Emil Gydesen <[email protected]>
Remove a duplicated advertising set in the CAP acceptor babblesim test. The advertising set is configured in test_start_adv. Signed-off-by: Emil Gydesen <[email protected]>
The BSIM test for the CAP acceptor used legacy instead of extended advertising. This also adds the required advertising data and validation on the CAP initiator and CAP commander. Signed-off-by: Emil Gydesen <[email protected]>
Align audio test Controller Kconfig value same as used with nRF53bsim. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Enable some high reliability CAP tests by increasing ISO Tx buffer counts in the Controller to sufficiently generate number of complete when multiple SDUs are transmitted in single ISO interval with use of pre-transmissions. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_tests_bsim_audio_ctlr_conf_2
branch
from
5522ef0
to
58ddb33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable some high reliability CAP tests by increasing ISO Tx buffer counts in the Controller to sufficiently generate number of complete when multiple SDUs are transmitted in single ISO interval with use of pre-transmissions.