snippets: nordic-*: support custom boards #80522
Conversation
zephyrbot
requested review from
anangl,
jaz1-nordic,
jeremybettis,
kl-cruz,
magp-nordic,
nashif,
nika-nordic,
nordicjm and
tejlmand
snippets/nordic-flpr-xip/snippet.yml
Outdated
| @@ -3,9 +3,9 @@ append: | |||
| EXTRA_DTC_OVERLAY_FILE: nordic-flpr-xip.overlay | |||
|
|
|||
| boards: | |||
| nrf54l15dk/nrf54l15/cpuapp: | |||
| /.*/nrf54l15/cpuapp/: | |||
| append: | |||
| EXTRA_DTC_OVERLAY_FILE: boards/nrf54l15dk_nrf54l15_cpuapp.overlay | |||
There was a problem hiding this comment.
Would prefer if these were moved to a socs directory and the nrf54l15dk part was dropped, it has no relation to the board anymore
Apply overlays for custom boards, based on already supported SoCs. Fixes zephyrproject-rtos#77639. Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
snip_match
branch
from
48eb62d
to
642ee9f
Compare
There was a problem hiding this comment.
overlay seems fairly tied to boards, so I'm not sure if this will actually work with any oot board, see eg https://github.com/zephyrproject-rtos/zephyr/blob/642ee9f2c342aabd5473f2cb526fc68053193631/snippets/nordic-flpr/soc/nrf54l15_cpuapp.overlay
@masz-nordic can you verify @gmarull concern? Was looking to bring this into 4.0 but want to ensure it's not going to break OOT boards. |
|
This works on an assumption that board is generated using genboard, since it generates board dts based on DK layout: If the custom board changes the memory layout, then similar changes have to be applied to a new overlay added to this snippet (perhaps this should be documented?). |
|
@anangl please take a look |
Apply overlays for custom boards, based on already supported SoCs.
Fixes #77639.