-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llext: add initial support for arc #80078
Conversation
24d19ec
to
44e70fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, one more arch on the list! 👍
(all tests pass with just 2 relocations?)
Perhaps that's due to -mlong-calls
. Not sure about the evils that may be unleashed dropping it though 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surface-level comments as I'm not well versed in ARC specifics:
3c9e29d
to
a3d0613
Compare
Added R_ARC_B26 and R_ARC_S25W_PCREL to support hs5/6x, still need to fix some build errors on hs5x Edit: Deferring build errors on two tests to another PR, to be linked with this issue |
a3d0613
to
b37c219
Compare
@laurenmurphyx64 what is that testsuite? May we look at it and see what kind of results it produces for ARC? |
We have 5 emulated ARC boards:
To run the testsuite on one (keep adding -p [BOARD NAME] to run on multiple boards):
You can check the output in
The tests output a lot of detail about relocations. Example:
The files in |
9ad6b0c
to
b9643a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Spotted 2 minor issues, not blockers but should probably be addressed in a followup PR.
Adds compiler flag(s) and some architecture-specific relocations for ARC. No userspace support, doesn't support all relocations. Signed-off-by: Lauren Murphy <[email protected]>
08057ca
b9643a8
to
08057ca
Compare
Adds compiler flag(s) and architecture-specific relocations for ARC.
Notes: