dma: nxp: edma: remove the hal-cfg-index property
#79906
Merged
+18
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentiuM1234
changed the title
hal-config-index propertyhal-cfg-index property
dbaluta
approved these changes
Oct 16, 2024
decsny
approved these changes
Oct 16, 2024
decsny
added
platform: NXP Drivers
LaurentiuM1234
requested review from
mmahadevan108,
dleach02 and
JiafeiPan
as code owners
zephyrbot
added
area: DMA
zephyrbot
requested review from
carlocaione,
danieldegrasse,
iuliana-prodan,
manuargue,
MarkWangChinese,
npitre,
povergoing,
SgrrZhf,
teburd and
yvanderv
iuliana-prodan
approved these changes
Oct 16, 2024
decsny
requested changes
Oct 16, 2024
There was a problem hiding this comment.
I actually just realized, this might break bisectibility due to removing the property in a commit before the binding change, I think it will cause an EDT error, please just squash those two commits into one (and honestly the whole PR could be a single commit)
LaurentiuM1234
force-pushed
the
feature/edma_binding_drop_prop
branch
from
5abf6e1
to
1eedc50
Compare
The HAL configuration binding can be done dynamically based on the IP's address space. The `hal-cfg-index` property is more tied to software rather than hardware so remove it as an attempt to clean up the binding. Signed-off-by: Laurentiu Mihalcea <[email protected]>
done |
dbaluta
approved these changes
Oct 17, 2024
decsny
approved these changes
Oct 17, 2024
nashif
approved these changes
Nov 8, 2024
teburd
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HAL configuration binding can be done dynamically based on the IP's address space. The
hal-config-indexproperty is more tied to software rather than hardware so remove it as an attempt to clean up the binding.