boards: lilygo: ttgo_lora32: enable SDHC support

[lfelten]

enable support for the SDHC controller to use the micro SD card slot

[danieldegrasse]

Can you add the sdhc tag to the list of features this board supports so the SDHC tests run on it?

zephyr/boards/nxp/lpcxpresso55s69/lpcxpresso55s69_lpc55s69_cpu0.yaml

Line 27 in 73a3438

- sdhc

Also, we should update the documentation page for this board to indicate SDHC support

[lfelten]

Thanks for you feedback!

Can you add the sdhc tag to the list of features this board supports so the SDHC tests run on it?
added

Also, we should update the documentation page for this board to indicate SDHC support
It mentioned SD before, I updated it to SDHC

[sylvioalves]

Now, add ' sdhc' to the ignore list in ttgo_lora32_esp32_appcpu.yaml.

[lfelten]

Now, add ' sdhc' to the ignore list in ttgo_lora32_esp32_appcpu.yaml.

Added it.
I also added CONFIG_ESP32_USE_UNSUPPORTED_REVISION=y in the procpu defconfig, which is required since I rebased to main

[lfelten]

This fails during linking, undefined symbols are ctime_r and asctime_r.
I'll rebase to main.

[sylvioalves]

This fails during linking, undefined symbols are ctime_r and asctime_r. I'll rebase to main.

Indeed. Fix in #79455.

[sylvioalves]

@lfelten please rebase.

[sylvioalves]

@lfelten Is this completed?

[kartben]

A nit and an actual request for change. Thanks for rebasing, too!

[kartben]

Can you add a comment on why this is needed (if this is needed?). This way it's not only clearer to the user but also helps knowing when we might be able to remove it in the future

[kartben]

Not blocking but I'd rather you link to the samples instead. I understand that this is useful to give ready to copy-paste build instructions but it's also content that might be left behind should something change in the way these samples should be built (arguably unlikely, but still)
I would simply say something like "You may also run :zephyr:code-sample:XXX to blah blah or ... to ...".

[lfelten]

Hi @kartben
Yes, I can change them to be links.
Since I usually compare with documentation files from other boards, is there a reference documentation you'd recommend? Especially how to make the links.
The copy-paste build instructions did actually change not so long ago, and I had to update them. So, removing those would be good.

[lfelten]

Should I add links like this?

• :zephyr:code-sample:lora-send
• :zephyr:code-sample:lora-receive
• :zephyr:code-sample:fs-fs-sample
• :zephyr:code-sample:display-cfb

(how do subdirectories/catgories get handled?)