Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAX32xxx RTC driver #78491

Closed
wants to merge 17 commits into from

Conversation

oknshn
Copy link
Contributor

@oknshn oknshn commented Sep 16, 2024

This PR adds RTC driver for ADI MAX32xxx series microcontrollers. Test configs for tests/drivers/rtc/rtc_api are provided for each board.

This commit instantiates RTC on MAX32xxx MCUs.

Co-authored-by: Sadik Ozer <[email protected]>
Signed-off-by: Okan Sahin <[email protected]>
oknshn and others added 16 commits September 16, 2024 18:33
This commit adds RTC driver for MAX32xxx MCUs

Co-authored-by: Furkan Akkiz <[email protected]>
Co-authored-by: Sadik Ozer <[email protected]>
Signed-off-by: Okan Sahin <[email protected]>
This commit enables RTC for MAX32655 EVKIT.
Default alarm count is set as 1

Co-authored-by: Sadik Ozer <[email protected]>
Signed-off-by: Okan Sahin <[email protected]>
This commit enables RTC for MAX32655 FTHR.
Default alarm count is set as 1

Co-authored-by: Sadik Ozer <[email protected]>
Signed-off-by: Okan Sahin <[email protected]>
Enable rtc driver test for max32655fthr and max32655EVKIT.

Signed-off-by: Okan Sahin <[email protected]>
This commit enables RTC for MAX32666 FTHR.
Default alarm count is set as 1

Co-authored-by: Okan Sahin <[email protected]>
Signed-off-by: Maureen Helm <[email protected]>
This commit enables RTC for MAX32666 EVKIT.
Default alarm count is set as 1

Co-authored-by: Okan Sahin <[email protected]>
Signed-off-by: Maureen Helm <[email protected]>
Enable rtc driver test for max32690evkit

Signed-off-by: Sadik Ozer <[email protected]>
This commit enables RTC for MAX32670 EVKIT.
Default alarm count is set as 1

Co-authored-by: Okan Sahin <[email protected]>
Signed-off-by: Maureen Helm <[email protected]>
Enable rtc driver test for max32670evkit

Signed-off-by: Sadik Ozer <[email protected]>
This commit enables RTC for MAX32672 EVKIT.
Default alarm count is set as 1

Co-authored-by: Okan Sahin <[email protected]>
Signed-off-by: Maureen Helm <[email protected]>
This commit enables RTC for MAX32672 FTHR.
Default alarm count is set as 1

Co-authored-by: Okan Sahin <[email protected]>
Signed-off-by: Maureen Helm <[email protected]>
Enable rtc driver test for max32672evkit and fthr boards

Signed-off-by: Sadik Ozer <[email protected]>
This commit enables RTC for MAX32662 EVKIT.
Default alarm count is set as 1

Co-authored-by: Okan Sahin <[email protected]>
Signed-off-by: Maureen Helm <[email protected]>
Enable rtc driver test for MAX32662EVKIT

Signed-off-by: Furkan Akkiz <[email protected]>
Enable rtc driver test for max32666fthr and max32666EVKIT

Co-authored-by: Furkan Akkiz <[email protected]>
Signed-off-by: Sadik Ozer <[email protected]>
This commit enables RTC for MAX32690 EVKIT.
Default alarm count is set as 1.

Co-authored-by: Okan Sahin <[email protected]>
Signed-off-by: Maureen Helm <[email protected]>
Copy link
Collaborator

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a real time clock from what I can tell, its a real time counter, which should be using the counter API (kind of). Converting time from clock calendar format to utc time like values should not be done in a low level driver.

We still don't have an API for real time counters, AKA low power low frequency counters for which the ticks can be set to a specific value. I would encourage you to propose one (or simply propose an optional ticks set API for the counter API)

@oknshn
Copy link
Contributor Author

oknshn commented Oct 18, 2024

This is not a real time clock from what I can tell, its a real time counter, which should be using the counter API (kind of). Converting time from clock calendar format to utc time like values should not be done in a low level driver.

We still don't have an API for real time counters, AKA low power low frequency counters for which the ticks can be set to a specific value. I would encourage you to propose one (or simply propose an optional ticks set API for the counter API)

Thanks for explanation. I am closing this PR, and opened a new one #80040

@oknshn oknshn closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: RTC Real Time Clock platform: ADI Analog Devices, Inc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants