driver: ssp: Refactor SSP driver to use SSP_IP_VER for version checks #78470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnikodem
force-pushed
the
update_macro_definition_for_ssp_driver
branch
2 times, most recently
from
24c0646
to
3253bd3
Compare
dnikodem
requested review from
kv2019i,
marcinszkudlinski and
abonislawski
as code owners
zephyrbot
requested review from
dbaluta,
iuliana-prodan,
juimonen,
LaurentiuM1234 and
lgirdwood
| #define SSP_IP_VER SSP_IP_VER_2_0 | ||
| #elif defined(CONFIG_SOC_INTEL_ACE30) | ||
| #define SSP_IP_VER SSP_IP_VER_3_0 | ||
| #endif |
There was a problem hiding this comment.
just suggestion:
#else
#error ...unknown HW...
#endif
There was a problem hiding this comment.
Yes, this is a good idea - I will change it. Thanks
dnikodem
force-pushed
the
update_macro_definition_for_ssp_driver
branch
2 times, most recently
from
617598f
to
5423804
Compare
dnikodem
force-pushed
the
update_macro_definition_for_ssp_driver
branch
from
5423804
to
760973b
Compare
tmleman
reviewed
Oct 29, 2024
dnikodem
force-pushed
the
update_macro_definition_for_ssp_driver
branch
from
760973b
to
fbe9fe6
Compare
tmleman
previously approved these changes
Oct 29, 2024
LaurentiuM1234
previously approved these changes
Nov 1, 2024
kv2019i
reviewed
Nov 4, 2024
drivers/dai/intel/ssp/ssp.c
Outdated
| @@ -1980,12 +1985,12 @@ static int dai_ssp_parse_tlv(struct dai_intel_ssp *dp, const uint8_t *aux_ptr, s | |||
| case SSP_LINK_CLK_SOURCE: | |||
| #ifdef CONFIG_SOC_SERIES_INTEL_ADSP_ACE | |||
There was a problem hiding this comment.
Should this be changed as well? #ifdef SSP_IP_VER >= SSP_IP_VER_1_5
There was a problem hiding this comment.
yes, good catch, thanks :)
This commit updates the SSP driver to use the newly defined SSP_IP_VER macros for IP version checks instead of relying on CONFIG_SOC_* macros. The change ensures better readability and maintainability by centralizing the IP version definitions and comparisons. Signed-off-by: Damian Nikodem <[email protected]>
dnikodem
force-pushed
the
update_macro_definition_for_ssp_driver
branch
from
fbe9fe6
to
e796e59
Compare
kv2019i
approved these changes
Nov 4, 2024
tmleman
approved these changes
Nov 6, 2024
softwarecki
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the SSP driver to use the newly defined SSP_IP_VER macros for IP version checks instead of relying on CONFIG_SOC_* macros. The change ensures better readability and maintainability by centralizing the IP version definitions and comparisons.