subsys: lorawan: add devicetime request support #78155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
JordanYates,
kartben,
Mani-Sadhasivam,
martinjaeger,
mniestroj and
nashif
kowalewskijan
force-pushed
the
lorawan-device-time-req
branch
from
53d07a0
to
02aab9b
Compare
kowalewskijan
force-pushed
the
lorawan-device-time-req
branch
from
02aab9b
to
c1d14cc
Compare
|
A clang format run seems to be required. Except that: LGTM. samples/subsys/lorawan/fuota/src/main.c shall be updated with the new callback definition |
Change downlink callback to transport data using flags. Related to Issue zephyrproject-rtos#55072 Co-authored-by: Jan Kowalewski <[email protected]> Signed-off-by: romain pelletant <[email protected]> Signed-off-by: Jan Kowalewski <[email protected]>
Add devicetime request support. Update lorawan sample Related to Issue zephyrproject-rtos#55072 Co-authored-by: Jan Kowalewski <[email protected]> Signed-off-by: romain pelletant <[email protected]> Signed-off-by: Jan Kowalewski <[email protected]>
kowalewskijan
force-pushed
the
lorawan-device-time-req
branch
from
c1d14cc
to
db3e79b
Compare
|
All issues resolved - CI is green |
JordanYates
reviewed
Oct 20, 2024
ADR status and devtime updated flags merged into an atomic bits array. Related to Issue zephyrproject-rtos#55072 Co-authored-by: Jan Kowalewski <[email protected]> Signed-off-by: romain pelletant <[email protected]> Signed-off-by: Jan Kowalewski <[email protected]>
kowalewskijan
force-pushed
the
lorawan-device-time-req
branch
from
db3e79b
to
c905ca5
Compare
JordanYates
approved these changes
Oct 27, 2024
mniestroj
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hijacked PR from #55073
According to comments vs. what was available on: https://github.com/RomainPelletant/zephyr/tree/subsys/lorawan/add-devicetime-request missing parts were:
lorawan_req_timehelper functiondata_pendingbool flag touint8_t flagsfield inmulticast_package_callbackfunction@martinjaeger @JordanYates @RomainPelletant - please let me know if there is anything I missed from the original PR discussion.