soc: infineon: Support for power management on 20829 #77901

sreeramIfx · 2024-09-03T05:08:25Z

- Initial changes in board, dts, and soc files to support system power management

gmarull · 2024-09-27T07:36:52Z

boards/infineon/cyw920829m2evk_02/cyw920829m2evk_02.dts

+	power-states {
+		idle: idle {
+			compatible = "zephyr,power-state";
+			power-state-name = "suspend-to-idle";
+			min-residency-us = <1000000>;
+		};
+
+		suspend_to_ram: suspend_to_ram {
+			compatible = "zephyr,power-state";
+			power-state-name = "suspend-to-ram";
+			min-residency-us = <2000000>;
+		};
+	};
+
+	cpus {
+		cpu@0 {
+			cpu-power-states = <&idle &suspend_to_ram>;
+		};
+	};


power states need to be part of soc dts files

moved the power states to soc dtsi files..

@gmarull, please review Sreeram's change at your convenience.

sreeramIfx · 2024-10-03T23:47:40Z

Build failure is addressed @ #79399

gmarull · 2024-10-04T06:54:09Z

soc/infineon/cat1b/cyw20829/power.c

+	return cyhal_syspm_init();
+}
+
+SYS_INIT(ifx_pm_init, PRE_KERNEL_1, CONFIG_KERNEL_INIT_PRIORITY_DEFAULT);


please, use hooks

updated to use hooks

gmarull · 2024-10-04T06:54:22Z

dts/arm/infineon/cat1b/cyw20829/cyw20829.dtsi

+		};
+	};
+
+	power-states {


not in cpus?

moved into the cpu node

gmarull · 2024-10-09T07:48:50Z

soc/infineon/cat1b/cyw20829/CMakeLists.txt

@@ -5,6 +5,8 @@ zephyr_sources(soc.c)
 zephyr_sources(app_header.c)
 zephyr_include_directories(.)

+zephyr_sources_ifdef(CONFIG_PM ./power.c)


Suggested change

zephyr_sources_ifdef(CONFIG_PM ./power.c)

zephyr_sources_ifdef(CONFIG_PM power.c)

gmarull · 2024-10-09T07:49:00Z

dts/arm/infineon/cat1b/cyw20829/cyw20829.dtsi

 		};
 	};

+


Suggested change

gmarull · 2024-10-09T07:49:12Z

soc/infineon/cat1b/cyw20829/Kconfig.defconfig

@@ -6,6 +6,13 @@

 if SOC_DIE_CYW20829

+config INFINEON_CAT1_LP_TIMER
+	bool
+	default n


Suggested change

default n

gmarull · 2024-10-09T07:49:35Z

soc/infineon/cat1b/cyw20829/power.c

+ * For deep sleep pm_system_suspend has executed all the driver
+ * power management call backs.
+ */
+__weak void pm_state_set(enum pm_state state, uint8_t substate_id)


Suggested change

__weak void pm_state_set(enum pm_state state, uint8_t substate_id)

void pm_state_set(enum pm_state state, uint8_t substate_id)

gmarull · 2024-10-09T07:49:45Z

soc/infineon/cat1b/cyw20829/power.c

+	}
+}
+
+__weak void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id)


Suggested change

__weak void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id)

void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id)

gmarull · 2024-10-09T07:50:11Z

soc/infineon/cat1b/cyw20829/power.c

+
+int ifx_pm_init(void)
+{
+#if defined(CONFIG_BOARD_CYW920829M2EVK_02)


-1 board selective code in soc, find a better way

gmarull · 2024-10-09T07:50:41Z

soc/infineon/cat1b/cyw20829/soc.c

+#ifdef CONFIG_PM
+	ifx_pm_init();
+#endif


ifdefout the entire hook?

gmarull · 2024-10-10T08:24:48Z

soc/infineon/cat1b/cyw20829/power.h

+void get_sleep_info(uint32_t *sleepattempts, uint32_t *sleepcounts, uint32_t *deepsleepattempts,
+		    uint32_t *deepsleepcounts, int64_t *sleeptime);
+


not used anywhere

ping, impl still there

@gmarull removed the implementation as well, please review

- Initial changes in board, dts, and soc files to support system power management Signed-off-by: Sreeram Tatapudi <[email protected]>

addressed

sreeramIfx force-pushed the topic/cyw20829_pm branch 4 times, most recently from be2db29 to 6599a3f Compare September 4, 2024 22:07

sreeramIfx marked this pull request as ready for review September 4, 2024 22:25

zephyrbot added the platform: Infineon Infineon Technologies AG label Sep 4, 2024

zephyrbot requested review from ifyall, npal-cy, parthitce and talih0 September 4, 2024 22:25

zephyrbot assigned ifyall Sep 4, 2024

ifyall previously approved these changes Sep 26, 2024

View reviewed changes

gmarull requested changes Sep 27, 2024

View reviewed changes

sreeramIfx dismissed ifyall’s stale review via 5408dad October 2, 2024 22:53

sreeramIfx force-pushed the topic/cyw20829_pm branch 2 times, most recently from 5408dad to dfd6c7e Compare October 2, 2024 23:10

gmarull reviewed Oct 4, 2024

View reviewed changes

sreeramIfx force-pushed the topic/cyw20829_pm branch 2 times, most recently from 4c878f5 to 4b48f56 Compare October 8, 2024 05:34

ifyall previously approved these changes Oct 8, 2024

View reviewed changes

sreeramIfx force-pushed the topic/cyw20829_pm branch from 4b48f56 to f528c03 Compare October 8, 2024 18:15

sreeramIfx requested a review from gmarull October 8, 2024 18:54

gmarull previously requested changes Oct 9, 2024

View reviewed changes

sreeramIfx dismissed ifyall’s stale review via cadf68d October 9, 2024 18:19

sreeramIfx force-pushed the topic/cyw20829_pm branch from f528c03 to cadf68d Compare October 9, 2024 18:19

ifyall previously approved these changes Oct 9, 2024

View reviewed changes

sreeramIfx requested a review from gmarull October 9, 2024 20:35

gmarull reviewed Oct 10, 2024

View reviewed changes

sreeramIfx dismissed ifyall’s stale review via 1a54d33 October 10, 2024 17:29

sreeramIfx force-pushed the topic/cyw20829_pm branch from cadf68d to 1a54d33 Compare October 10, 2024 17:29

sreeramIfx requested a review from gmarull October 11, 2024 05:03

soc: infineon: Support for power management on 20829

3cea7c8

- Initial changes in board, dts, and soc files to support system power management Signed-off-by: Sreeram Tatapudi <[email protected]>

sreeramIfx force-pushed the topic/cyw20829_pm branch from 1a54d33 to 3cea7c8 Compare October 24, 2024 23:19

sreeramIfx requested a review from ifyall November 5, 2024 00:12

ifyall approved these changes Nov 5, 2024

View reviewed changes

npal-cy approved these changes Nov 15, 2024

View reviewed changes

nashif merged commit 0a9c0f4 into zephyrproject-rtos:main Nov 16, 2024
25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

soc: infineon: Support for power management on 20829 #77901

soc: infineon: Support for power management on 20829 #77901

sreeramIfx commented Sep 3, 2024

gmarull Sep 27, 2024

sreeramIfx Oct 2, 2024

ifyall Oct 3, 2024

sreeramIfx commented Oct 3, 2024

gmarull Oct 4, 2024

sreeramIfx Oct 8, 2024

gmarull Oct 4, 2024

sreeramIfx Oct 8, 2024

gmarull Oct 9, 2024

gmarull Oct 9, 2024

gmarull Oct 9, 2024

gmarull Oct 9, 2024

gmarull Oct 9, 2024

gmarull Oct 9, 2024

gmarull Oct 9, 2024

gmarull Oct 10, 2024

gmarull Oct 15, 2024

sreeramIfx Oct 24, 2024 •

edited

Loading

	zephyr_sources_ifdef(CONFIG_PM ./power.c)
	zephyr_sources_ifdef(CONFIG_PM power.c)

	__weak void pm_state_set(enum pm_state state, uint8_t substate_id)
	void pm_state_set(enum pm_state state, uint8_t substate_id)

	__weak void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id)
	void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id)

		void get_sleep_info(uint32_t sleepattempts, uint32_t sleepcounts, uint32_t *deepsleepattempts,
		uint32_t deepsleepcounts, int64_t sleeptime);

soc: infineon: Support for power management on 20829 #77901

soc: infineon: Support for power management on 20829 #77901

Conversation

sreeramIfx commented Sep 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sreeramIfx commented Oct 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sreeramIfx Oct 24, 2024 • edited Loading

Choose a reason for hiding this comment

sreeramIfx Oct 24, 2024 •

edited

Loading