tests: Bluetooth: Audio: Cap broadcast reception stop bsim tests #76266
+66
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruithofa
force-pushed
the
CAP_broadcast_reception_stop_bsim
branch
from
352c417
to
d01b8c8
Compare
kruithofa
force-pushed
the
CAP_broadcast_reception_stop_bsim
branch
3 times, most recently
from
b57d791
to
8c01cd4
Compare
kruithofa
added
area: Bluetooth
area: Bluetooth Audio
and removed
DNM
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr,
sjanc and
Thalley
Thalley
requested changes
Oct 31, 2024
Comment on lines
+404
to
+412
| uint32_t total_bis = 0U; | ||
|
|
||
| broadcaster_broadcast_id = recv_state->broadcast_id; | ||
| if (bis_sync_req[0] != 0) { | ||
|
|
||
| for (int i = 0; i < recv_state->num_subgroups; i++) { | ||
| total_bis |= bis_sync_req[i]; | ||
| } | ||
|
|
||
| if (total_bis != 0U) { |
There was a problem hiding this comment.
total_bis should be used in create_and_sync_sink to determine which BIS to sync to.
Keep in mind that the value of bis_sync_req[i] may be BT_BAP_BIS_SYNC_NO_PREF
This is arguably outside the scope of this PR, as the existing test is not using the sync value from the broadcast assistant.
kruithofa
force-pushed
the
CAP_broadcast_reception_stop_bsim
branch
from
8c01cd4
to
c07fedd
Compare
Thalley
requested changes
Nov 5, 2024
Implement a babblesim test for the CAP broadcast reception stop procedure Signed-off-by: Andries Kruithof <[email protected]>
kruithofa
force-pushed
the
CAP_broadcast_reception_stop_bsim
branch
from
c07fedd
to
73cfe6c
Compare
Thalley
approved these changes
Nov 5, 2024
larsgk
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a babblesim test for the CAP broadcast reception stop procedure