Skip to content

Add support for IPV6_MULTICAST_IF and IP_MULTICAST_IF socket options #160743

Add support for IPV6_MULTICAST_IF and IP_MULTICAST_IF socket options

Add support for IPV6_MULTICAST_IF and IP_MULTICAST_IF socket options #160743

Triggered via pull request November 15, 2024 15:12
Status Failure
Total duration 2m 44s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
2m 33s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

5 errors, 3 warnings, and 10 notices
CODE_INDENT: include/zephyr/net/socket.h#L1215
include/zephyr/net/socket.h:1215 code indent should use tabs where possible
CODE_INDENT: include/zephyr/net/socket.h#L1216
include/zephyr/net/socket.h:1216 code indent should use tabs where possible
Run compliance checks on patch series (PR)
Process completed with exit code 2.
Run compliance checks on patch series (PR): Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. CODE_INDENT: code indent should use tabs where possible File:include/zephyr/net/socket.h Line:1215 LEADING_SPACE: please, no spaces at the start of a line File:include/zephyr/net/socket.h Line:1215 CODE_INDENT: code indent should use tabs where possible File:include/zephyr/net/socket.h Line:1216 LEADING_SPACE: please, no spaces at the start of a line File:include/zephyr/net/socket.h Line:1216
Run compliance checks on patch series (PR)
Process completed with exit code 1.
LEADING_SPACE: include/zephyr/net/socket.h#L1215
include/zephyr/net/socket.h:1215 please, no spaces at the start of a line
LEADING_SPACE: include/zephyr/net/socket.h#L1216
include/zephyr/net/socket.h:1216 please, no spaces at the start of a line
Run compliance checks on patch series (PR): ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: - net_ipv6_addr_copy_raw(NET_IPV6_HDR(cloned)->src, - NET_IPV6_HDR(pkt)->dst); - net_ipv6_addr_copy_raw(NET_IPV6_HDR(cloned)->dst, - NET_IPV6_HDR(pkt)->src); + net_ipv6_addr_copy_raw(NET_IPV6_HDR(cloned)->src, NET_IPV6_HDR(pkt)->dst); + net_ipv6_addr_copy_raw(NET_IPV6_HDR(cloned)->dst, NET_IPV6_HDR(pkt)->src); } else { - net_ipv4_addr_copy_raw(NET_IPV4_HDR(cloned)->src, - NET_IPV4_HDR(pkt)->dst); - net_ipv4_addr_copy_raw(NET_IPV4_HDR(cloned)->dst, - NET_IPV4_HDR(pkt)->src); + net_ipv4_addr_copy_raw(NET_IPV4_HDR(cloned)->src, NET_IPV4_HDR(pkt)->dst); + net_ipv4_addr_copy_raw(NET_IPV4_HDR(cloned)->dst, NET_IPV4_HDR(pkt)->src); File:drivers/net/loopback.c Line:151 You may want to run clang-format on this change: - NET_OPT_MCAST_IFINDEX = 19, /**< IPv6 multicast output network interface index */ + NET_OPT_MCAST_IFINDEX = 19, /**< IPv6 multicast output network interface index */ File:include/zephyr/net/net_context.h Line:1312 You may want to run clang-format on this change: -#define IP_MULTICAST_IF 32 +#define IP_MULTICAST_IF 32 File:include/zephyr/net/socket.h Line:1195 You may want to run clang-format on this change: -struct ip_mreq { - struct in_addr imr_multiaddr; /**< IP multicast group address */ - struct in_addr imr_interface; /**< IP address of local interface */ +struct ip_mreq { + struct in_addr imr_multiaddr; /**< IP multicast group address */ + struct in_addr imr_interface; /**< IP address of local interface */ File:include/zephyr/net/socket.h Line:1217 You may want to run clang-format on this change: -#define IPV6_MULTICAST_IF 17 +#define IPV6_MULTICAST_IF 17 File:include/zephyr/net/socket.h Line:1231 You may want to run clang-format on this change: - net_ipv4_is_addr_bcast(net_context_get_iface(context), - &addr4->sin_addr))) { + net_ipv4_is_addr_bcast(net_context_get_iface(context), &addr4->sin_addr))) { File:subsys/net/ip/net_context.c Line:1314 You may want to run clang-format on this change: -static int get_context_mcast_ifindex(struct net_context *context, - void *value, size_t *len) +static int get_context_mcast_ifindex(struct net_context *context, void *value, size_t *len) File:subsys/net/ip/net_context.c Line:1804 You may want to run clang-format on this change: - if (IS_ENABLED(CONFIG_NET_UDP) && - net_context_get_type(context) == SOCK_DGRAM) { + if (IS_ENABLED(CONFIG_NET_UDP) && net_context_get_type(context) == SOCK_DGRAM) { File:subsys/net/ip/net_context.c Line:2099 You may want to run clang-format on this change: - if (net_ipv6_is_addr_unspecified( - &net_sin6(&context->remote)->sin6_addr) && + if (net_ipv6_is_addr_unspecified(&net_sin6(&context->remote)->sin6_addr) && File:subsys/net/ip/net_context.c Line:2118 You may want to run clang-format on this change: - if (IS_ENABLED(CONFIG_NET_UDP) && - net_context_get_type(context) == SOCK_DGRAM) { + if (IS_ENABLED(CONFIG_NET_UDP) && net_context_get_type(context) == SOCK_DGRAM) { File:subsys/net/ip/net_context.c Line:2165 You may want to run clang-format on this change: -static int set_context_mcast_ifindex(struct net_context *context, - const void *value, size_t len) +static int set_context_mcast_ifindex(struct net_context *context, const void *value, size_t len) File:subsys/net/ip/net_context.c Line:3220 You may want to run clang-format on this change: -static int ipv4_multicast_if(struct net_context *ctx, const void *optval, - socklen_t optlen, bool do_get) +static int ipv4_multicast_if(struct net_context *ctx, const void *optval, socklen_t optlen, + bool do_get) File:subsys/net/lib/sockets/sockets_inet.c Line:1617 You may want to run clang-format on this change: - ret = net_context_get_option(ctx, NET_OPT_MCAST_IFINDEX, - &ifindex, &len); + ret = net_context_get_option(ctx, NET_OPT_MCAS
You may want to run clang-format on this change: drivers/net/loopback.c#L151
drivers/net/loopback.c:151 - net_ipv6_addr_copy_raw(NET_IPV6_HDR(cloned)->src, - NET_IPV6_HDR(pkt)->dst); - net_ipv6_addr_copy_raw(NET_IPV6_HDR(cloned)->dst, - NET_IPV6_HDR(pkt)->src); + net_ipv6_addr_copy_raw(NET_IPV6_HDR(cloned)->src, NET_IPV6_HDR(pkt)->dst); + net_ipv6_addr_copy_raw(NET_IPV6_HDR(cloned)->dst, NET_IPV6_HDR(pkt)->src); } else { - net_ipv4_addr_copy_raw(NET_IPV4_HDR(cloned)->src, - NET_IPV4_HDR(pkt)->dst); - net_ipv4_addr_copy_raw(NET_IPV4_HDR(cloned)->dst, - NET_IPV4_HDR(pkt)->src); + net_ipv4_addr_copy_raw(NET_IPV4_HDR(cloned)->src, NET_IPV4_HDR(pkt)->dst); + net_ipv4_addr_copy_raw(NET_IPV4_HDR(cloned)->dst, NET_IPV4_HDR(pkt)->src);
You may want to run clang-format on this change: include/zephyr/net/net_context.h#L1312
include/zephyr/net/net_context.h:1312 - NET_OPT_MCAST_IFINDEX = 19, /**< IPv6 multicast output network interface index */ + NET_OPT_MCAST_IFINDEX = 19, /**< IPv6 multicast output network interface index */
You may want to run clang-format on this change: include/zephyr/net/socket.h#L1195
include/zephyr/net/socket.h:1195 -#define IP_MULTICAST_IF 32 +#define IP_MULTICAST_IF 32
You may want to run clang-format on this change: include/zephyr/net/socket.h#L1217
include/zephyr/net/socket.h:1217 -struct ip_mreq { - struct in_addr imr_multiaddr; /**< IP multicast group address */ - struct in_addr imr_interface; /**< IP address of local interface */ +struct ip_mreq { + struct in_addr imr_multiaddr; /**< IP multicast group address */ + struct in_addr imr_interface; /**< IP address of local interface */
You may want to run clang-format on this change: include/zephyr/net/socket.h#L1231
include/zephyr/net/socket.h:1231 -#define IPV6_MULTICAST_IF 17 +#define IPV6_MULTICAST_IF 17
You may want to run clang-format on this change: subsys/net/ip/net_context.c#L1314
subsys/net/ip/net_context.c:1314 - net_ipv4_is_addr_bcast(net_context_get_iface(context), - &addr4->sin_addr))) { + net_ipv4_is_addr_bcast(net_context_get_iface(context), &addr4->sin_addr))) {
You may want to run clang-format on this change: subsys/net/ip/net_context.c#L1804
subsys/net/ip/net_context.c:1804 -static int get_context_mcast_ifindex(struct net_context *context, - void *value, size_t *len) +static int get_context_mcast_ifindex(struct net_context *context, void *value, size_t *len)
You may want to run clang-format on this change: subsys/net/ip/net_context.c#L2099
subsys/net/ip/net_context.c:2099 - if (IS_ENABLED(CONFIG_NET_UDP) && - net_context_get_type(context) == SOCK_DGRAM) { + if (IS_ENABLED(CONFIG_NET_UDP) && net_context_get_type(context) == SOCK_DGRAM) {
You may want to run clang-format on this change: subsys/net/ip/net_context.c#L2118
subsys/net/ip/net_context.c:2118 - if (net_ipv6_is_addr_unspecified( - &net_sin6(&context->remote)->sin6_addr) && + if (net_ipv6_is_addr_unspecified(&net_sin6(&context->remote)->sin6_addr) &&
You may want to run clang-format on this change: subsys/net/ip/net_context.c#L2165
subsys/net/ip/net_context.c:2165 - if (IS_ENABLED(CONFIG_NET_UDP) && - net_context_get_type(context) == SOCK_DGRAM) { + if (IS_ENABLED(CONFIG_NET_UDP) && net_context_get_type(context) == SOCK_DGRAM) {

Artifacts

Produced during runtime
Name Size
compliance.xml
3.71 KB