Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEN-29068: For upgrades, a separate log file needs to be generated fo… #543

Closed
wants to merge 2 commits into from

Conversation

olst
Copy link

@olst olst commented Aug 9, 2018

No description provided.

…r Monitoring Template changes/conflicts/remediations
@olst olst requested a review from j053ph4 August 13, 2018 06:13
Copy link
Contributor

@j053ph4 j053ph4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to take some time to review this, since this particular part of ZPL has had numerous revisions and is a bit tricky. My intent has been to move all of the "audit" code into a separate class since it gets used elsewhere in ZPL (and in unit tests) and also because it complicates the ZenPack class unnecessarily. Unless there's a pressing need to have this in the hotfix branch, my inclination would be to make these changes to develop, especially since (as you noted in JIRA) there are several different scenarios (upgrades from legacy or ZPL1, for example), that come into play as well.

@j053ph4
Copy link
Contributor

j053ph4 commented Aug 15, 2018

Another thought -- if this is a particular pain point for vSphere ZP, what about making these changes in a ZenPack class override in the vSphere ZP init (ZenPack) class?

@olst
Copy link
Author

olst commented Aug 16, 2018

The request was to save all templates' diffs into a separate place. This is not related only to vSphere ZP.

@olst
Copy link
Author

olst commented Aug 16, 2018

please see #544

@dougsyer
Copy link

Would be nice to be able to duel log all zplib commamds to a separate log thst is set to go to kibana. Also be able to have it use a different level of severity than what goes to stdout.

When i install a zenpack i just want to know if tgerr are errors amd it should be essy to see then refer to a detailed log for details om success or failure.

Also there is no clesr indicator that a zp sucrssfully installed and the errored output usually makes it clear something went wrong but its inconsistent so i find auromating it with a lipeline and checking for failures to be difficult

@cluther cluther closed this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants