fix: Fix checkbox behavior in zen-settings.js and update styles in ze…

…n-preferences.css
zen-browser · Aug 17, 2024 · a8980ae · a8980ae
1 parent 02fe8a0
commit a8980ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/browser/components/preferences/zen-settings.js b/src/browser/components/preferences/zen-settings.js
@@ -122,10 +122,10 @@ var gZenMarketplaceManager = {
             fragment.querySelector(".zenThemeMarketplaceItemPreferenceCheckbox").setAttribute("checked", "true");
           }
           fragment.querySelector(".zenThemeMarketplaceItemPreferenceCheckbox").addEventListener("click", (event) => {
-            let target = event.target;
+            let target = event.target.closest(".zenThemeMarketplaceItemPreferenceCheckbox");
             let key = target.getAttribute("zen-pref");
             let checked = target.hasAttribute("checked");
-            if (checked) {
+            if (!checked) {
               target.removeAttribute("checked");
             } else {
               target.setAttribute("checked", "true");

diff --git a/src/browser/themes/shared/preferences/zen-preferences.css b/src/browser/themes/shared/preferences/zen-preferences.css
@@ -304,7 +304,7 @@ groupbox h2 {
 .zenThemeMarketplaceItem {
   width: 100%;
 
-  &:not(:first-of-type) {
+  &:not(:first-of-type), .zenThemeMarketplaceItemPreferences {
     margin-top: 15px;
   }
 }