Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml: Improve highlighting and bracketing #20700

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lord
Copy link

@lord lord commented Nov 14, 2024

Some small improvements to OCaml. Would happily split these into smaller changes, discard anything, etc.

Before:
before

After:
after

OCaml highlighting and bracketing improvements
- Fixed bug where < was automatically closed with >.
- Typing {| now automatically closes with |}
- Type variables are now colored with variable.special instead of variable.
- Argument names in function declarations and application are now colored with label instead of property, even if they are punned.
- [@@ and [% in macros are now colored as bracket punctuation to match the closing ], rather than colored as attribute

Release Notes:

  • N/A

Copy link

cla-bot bot commented Nov 14, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @lord on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@lord
Copy link
Author

lord commented Nov 14, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 14, 2024
Copy link

cla-bot bot commented Nov 14, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title OCaml highlighting and bracketing improvements ocaml: Improve highlighting and bracketing Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant