Fix scrollbar not always being on top #20665
Conversation
…outline is no longer above the scrollbar. This should fix zed-industries#19875
cla-bot
bot
added
the
cla-signed
| @@ -2982,8 +2982,9 @@ impl ProjectPanel { | |||
| .right_1() | |||
| .top_1() | |||
| .bottom_1() | |||
| .w(px(12.)) | |||
There was a problem hiding this comment.
This seems like an unnecessary drive-by change? /cc @iamnbutler
There was a problem hiding this comment.
I changed the width because otherwise there would be a gap between the right side of the scroll handle and where the blue border continues:
In my opinion it looks better like this:
but i think it's a matter of taste
There was a problem hiding this comment.
Maybe this could be solved in a different way, but i don't know how, this is my first contribution to this project
There was a problem hiding this comment.
Oh yes, this definitely looks better, though I think we should find out where that background originates from and trim that instead. :P
maxdeviant
changed the title
|
It looks like this change causes the background of scrollbar show up unconditionally. We probably need render_vertical_scrollbar to return None if |
The blend function is used to blend the scrollbar color (scrollbar_thumb_background) on top of the background color (surface background). This way the color of the scrollbar stays the same, but it is no longer transparent, so that the blue border of selected files can't shine through and appear as if it was above the scrollbar.
|
I now found a possibly better solution to the problem with the blue border appearing on top of the scrollbar: And now the background of the scrollbar doesn't appear when there is no scrollbar: |
Set the elevation of the scrollbar to 1 borderless, so that the blue outline is no longer above the scrollbar.
Closes #19875
Release Notes: