Introduce devcontainer.json #710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
reviewed
Sep 5, 2023
|
You can see a sample of how Codespaces works by visiting the source branch of this PR and clicking the "<> Code" button:
|
daira
reviewed
Sep 8, 2023
daira
reviewed
Sep 8, 2023
daira
requested changes
Sep 8, 2023
AArnott
force-pushed
the
devcontainer
branch
4 times, most recently
from
49e9b32
to
c192616
Compare
daira
reviewed
Sep 9, 2023
AArnott
commented
Mar 3, 2024
daira
reviewed
Oct 22, 2024
There was a problem hiding this comment.
I don't like that this is a duplicate / near-duplicate of Dockerfile in the root. Can it be a symlink or otherwise deduplicated (e.g. by importing one Dockerfile into another)? Otherwise it's a bitrot hazard (because most devs are unlikely to be using both of them).
This ensures that VS Code or GitHub Codespaces can automatically create an environment where `make` can build the rst files. It also enables the rst preview pane in VS Code or GitHub Codespaces.
|
I pushed a change that eliminates the duplication. But I can't fully validate it because for some reason there's an issue with a build error that even appears (for me) on Any suggestions as to why this would show up? Also, I'm curious why the PR doesn't include validation by running this build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that VS Code or GitHub Codespaces can automatically create an environment where
makecan build the rst files.Learn more about GitHub Codespaces.
This root repo should consider setting up a prebuild of the Codespace because the Dockerfile takes several minutes to run, and with a prebuild, anyone can create a Codespace in seconds.