ZIP 316 updates for Unified Raw Encodings #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
reviewed
Jan 11, 2023
dconnolly
reviewed
Jan 11, 2023
Signed-off-by: Daira Emma Hopwood <[email protected]>
daira
force-pushed
the
zip-316-raw-encoding
branch
from
e6dbb9d
to
6491a54
Compare
daira
changed the title
daira
force-pushed
the
zip-316-raw-encoding
branch
from
6491a54
to
05ecd08
Compare
daira
commented
Mar 22, 2023
|
|
||
| There are well-defined transformations between the Unified QR Encoding, | ||
| Unified String Encoding, and Unified Raw Encoding of a given UA/UVK in | ||
| any direction. |
There was a problem hiding this comment.
Separately say that there is a UQRE <-> USE correspondence and a USE <-> URE correspondence.
daira
commented
Mar 22, 2023
| Similarly, a Unified Full Viewing Key or Unified Incoming Viewing Key | ||
| provides the corresponding visibility into transactions that may use | ||
| addresses of different types. Typically these will be the addresses | ||
| for each pool derived from an Account as defined in [#zip-0032-specification-wallet-usage]_. |
There was a problem hiding this comment.
Suggested change
| for each pool derived from an Account as defined in [#zip-0032-specification-wallet-usage]_. | |
| for each pool derived for an Account as defined in [#zip-0032-specification-wallet-usage]_. |
daira
commented
Mar 22, 2023
| addresses of different types. Typically these will be the addresses | ||
| for each pool derived from an Account as defined in [#zip-0032-specification-wallet-usage]_. | ||
| (It is not possible for a UVK to include viewing keys for multiple | ||
| addresses of the same type.) |
There was a problem hiding this comment.
Suggested change
| addresses of the same type.) | |
| addresses associated with the same pool.) |
daira
commented
Mar 22, 2023
| (i.e. the remainder of the Unified Raw Encoding after the Binary HRP). | ||
|
|
||
| 2. Let :math:`\mathtt{padded\_hrp}` be :math:`\mathtt{hrp}` padded to | ||
| 16 bytes with zero bytes. |
There was a problem hiding this comment.
Suggested change
| 16 bytes with zero bytes. | |
| 16 bytes with bytes of value 0. |
daira
commented
Mar 22, 2023
| supported (for example, a Testnet HRP for a Consumer that only supports | ||
| Mainnet), reject. | ||
| 2. Let :math:`\mathtt{expected\_padded\_hrp}` be the US-ASCII-encoded HRP, | ||
| padded to 16 bytes with zero bytes. |
There was a problem hiding this comment.
Suggested change
| padded to 16 bytes with zero bytes. | |
| padded to 16 bytes with bytes of value 0. |
dconnolly
approved these changes
Mar 22, 2023
daira
commented
Mar 22, 2023
There was a problem hiding this comment.
This was reviewed in ZIP sync with @dconnolly, @nuttycom, @sellout, @teor2345, and me present.
daira
commented
Mar 23, 2023
Comment on lines
+264
to
+266
| There are well-defined transformations between the Unified QR Encoding, | ||
| Unified String Encoding, and Unified Raw Encoding of a given UA/UVK in | ||
| any direction. |
There was a problem hiding this comment.
Suggested change
| There are well-defined transformations between the Unified QR Encoding, | |
| Unified String Encoding, and Unified Raw Encoding of a given UA/UVK in | |
| any direction. | |
| There are well-defined bidirectional transformations between the | |
| Unified String Encoding and Unified Raw Encoding, and between the | |
| Unified String Encoding and Unified QR Encoding of a given UA or UVK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daira Hopwood [email protected]