-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Zashi pipeline renderer #67
Conversation
with open('public/zcash-change-deployment-pipeline.html', 'w') as f: | ||
f.write(html_header) | ||
|
||
for issue in tracked_issues.values(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current limitation: we don't filter out rows where everything is complete. That is intentional for now while we start filling out the DAG with the necessary data, but eventually we'll want to hide rows that are no longer relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be useful to sort completed rows by their recency of completion, and then keep a minimum number for each platform and/or all the ones that were completed up to a given time ago.
For example: at least two completed rows for iOS, at least two completed rows for Android, and everything completed in the last 8 days. That would fit well with weekly meetings (8 days so that we don't miss anything that gets completed around the same time as a meeting).
In GitHub's GraphQl API, when an issue was closed is available in its closedAt
attribute, documented here: https://docs.github.com/en/graphql/reference/objects#issue
b78137f
to
564764f
Compare
This shows the progress of implementing tracked bugs and features, and deploying them to the mobile SDKs and Zashi apps. Closes #64.
564764f
to
a666c1a
Compare
zashi-pipeline.py
Outdated
return | ||
|
||
# Release not found in this repo | ||
f.write('<td>📥</td>') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful for this to link to the list of C-release
issues for the repository, so that if a blocking relationship is missing then the correct release issue can be readily found (or created) and the relationship updated.
f.write('<td>📥</td>') | |
f.write('<td><a href="https://github.com/{}/labels/C-release">📥</a></td>'.format(repo_id)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested ACK 29c7e5a, this will be a good starting point.l
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-hoc ACK
Closes #64.