zfsbootmenu: generalize zbm.import_delay as zbm.retry_delay #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahesford
approved these changes
Jan 16, 2024
zdykstra
force-pushed
the
untitle-branch-number-73
branch
from
fcac328 to
8185ab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding the retry delay for
zbm.wait_fordevices to 3 seconds, use the same interval aszbm_import_delay. The option has been renamed and the old value has been marked as deprecated. The major change in this is actually in documentation. I think the wording for thezbm.retry_delayoption is clear, but any changes to it are welcome.