Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for default argument value of macros #70

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

zackad
Copy link
Owner

@zackad zackad commented Oct 27, 2024

Close GH-69

@zackad
Copy link
Owner Author

zackad commented Nov 4, 2024

Missing quote when printing string value as default argument.

Expected output

+ {% macro hosted(
+     fontFamily,
+     filenameWithoutExt = false,
+     fontWeight = 400,
+     fontStyle = 'normal',
+     preload = false)
+ %}

Actual output

+ {% macro hosted(
+     fontFamily,
+     filenameWithoutExt = false,
+     fontWeight = 400,
+     fontStyle = normal,
+     preload = false)
+ %}

@zackad zackad marked this pull request as ready for review November 4, 2024 06:57
@zackad zackad changed the title [WIP] Feature: Add support for default argument value of macros Feature: Add support for default argument value of macros Nov 4, 2024
@zackad zackad force-pushed the GH-69/macros-arguments branch from 26bff1e to 39fcfb6 Compare November 10, 2024 01:17
@zackad zackad merged commit 39fcfb6 into master Nov 10, 2024
2 checks passed
@zackad zackad deleted the GH-69/macros-arguments branch November 10, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default arguments in macros aren't supported
1 participant