forked from trivago/prettier-plugin-twig-melody
-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add support for spread operator #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackad
force-pushed
the
spread-operator
branch
from
August 27, 2024 03:29
3aa1bc5
to
7d57f22
Compare
Example of spread operator usage from twig documentation. {% set numbers = [1, 2, ...moreNumbers] %}
{% set ratings = {'q1': 10, 'q2': 5, ...moreRatings} %}
{{ 'Hello %s %s!'|format(...['Fabien', 'Potencier']) }} |
zackad
commented
Oct 5, 2024
zackad
force-pushed
the
spread-operator
branch
from
November 16, 2024 01:17
7d57f22
to
d5d33dc
Compare
zackad
changed the title
[WIP] Feature: Add support for spread operator
Feature: Add support for spread operator
Nov 16, 2024
zackad
commented
Nov 16, 2024
zackad
commented
Nov 16, 2024
zackad
commented
Nov 16, 2024
rellafella
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have just left the comment there about the precedence of the spread operator. My understanding is that as long as the precedence score is lower than that of the range operator ..
(25), it should be fine.
zackad
force-pushed
the
spread-operator
branch
from
November 20, 2024 11:22
ae4cbe0
to
5b1399a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close GH-44.
Partially depends on GH-16.
Need help on how to parse this expression