Refactor: Don't use alias to export print function #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modular print function has signature
```js
const p = (node, path, print, options) => {
// function body here
}
```
It is easy to recognise which is the main function responsibe to build
the doc. Unfortunately it has to be aliased when exported to prevent
name collision. And it is not obvious where the callstack come from when
debugging since it share the same name across multiple file/module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modular print function has signature
It is easy to recognise which is the main function responsibe to build the doc. Unfortunately it has to be aliased when exported to prevent name collision. And it is not obvious where the callstack come from when debugging since it share the same name across multiple file/module.
With Alias
No Alias
