Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GiST support #7

Closed
wants to merge 1 commit into from
Closed

[WIP] GiST support #7

wants to merge 1 commit into from

Conversation

zachasme
Copy link
Owner

We have implemented basic SP-GiST support.

We are going to experiment with regular GiST index support on this branch as well.

@zachasme zachasme force-pushed the feature-more-operators branch 2 times, most recently from cc89091 to 7835d69 Compare August 29, 2019 15:17
@zachasme zachasme mentioned this pull request Oct 11, 2019
@zachasme zachasme self-assigned this Oct 11, 2019
@zachasme zachasme force-pushed the feature-more-operators branch 2 times, most recently from 8e7d009 to 6c9acd7 Compare October 15, 2019 10:52
@AbelVM AbelVM mentioned this pull request Mar 7, 2020
@zachasme zachasme mentioned this pull request Apr 14, 2020
@AbelVM
Copy link

AbelVM commented Aug 13, 2020

How can we help? 🔨

@zachasme zachasme added the help wanted ⛏️ Extra attention is needed label Aug 14, 2020
@zachasme
Copy link
Owner Author

If I recall correctly, the state of the branch (which hasn't been touched in a year 😮) is that we managed to get GiST and SP-GiST operator classes to compile and run. However, tests either returned wrong results or were significantly slower than no index. There probably is either a logical error or a misimplementation of (SP-)GiST.

Help is very much welcomed!

The branch should be rebased (or maybe it's easier to simply copy the opclass since so much has changed). Then, we need to figure out what is wrong with our implementation. My implementation is based off the SP-GiST docs and GiST docs but if anyone has some other reference implementation that could be helpful.

@AbelVM
Copy link

AbelVM commented Aug 14, 2020

Roger that. Let's move the conversation to the linked issue!

@zachasme zachasme force-pushed the feature-more-operators branch from 6c9acd7 to 6db18d2 Compare August 24, 2020 09:43
This was referenced Aug 24, 2020
@zachasme
Copy link
Owner Author

Closing in favor of #42.

@zachasme zachasme closed this Aug 24, 2020
@zachasme zachasme deleted the feature-more-operators branch October 1, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted ⛏️ Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants