-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yt-dlp fallback for stream extraction #1768
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14305798 | Triggered | Google API Key | 35653ef | innertube/src/main/java/com/zionhuang/innertube/models/YouTubeClient.kt | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Tried it and it works for non-age-restricted videos whether logged in or out, but it doesn't work for age restricted videos when logged in (or out, naturally). Gives "Unknown error." Unsure if it's the same error, i'll see if I can log it when I get home. Unrelated to this, but making the app actually display the error message instead of not giving any info would be great for an app that is subject to the whims of the yt api. I'll look into implementing a "See error details" button or something once this wave of blockage is resolved. |
hm it should work
I agree the error messages should be improved at some point. I already added a |
Seems like #1772 may be a cleaner solution, especially in regards to the APK size |
I know about this PR and would prefer it. The problem is that it doesn't support login and things like volume normalization due to missing metadata. To solve this I created a new PR which still supports login, has all metadata and keeps the app small and fast: |
closing in favor of #1774 |
This should fix the current playback issues: #1748
This is not a perfect solution:
But in my testing so far it works.
If you have a better idea feel free to share.
I tried to counter the slowness by only using this as a fallback for now.
In the long term it might be more reliable to offload more to yt-dlp.
I know the code is not the best. We can improve on that later.
However it should be fine for now as a quick fix.
Needs more testing.
TODO - before release:
- disable sending login info when using IOS client (it does not support login anymore but results in an error) DONE
TODO - for later:
Note: This also contains a temporary change to set the cookie value to null if the user is logged out (because only null is considered logged-out). It can be removed after #1694 is done.