-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading premium exclusive albums for premium accounts #1636
Conversation
NOTE: For some reason you set
UPDATE: New PR is up fixing this: #1637 |
Only downside is that we have to send the login cookie in more places so it makes it slightly worse for privacy. Note: for now the login cookie is not sent on search requests. This means that premium albums will not show in searches but only when opening artist pages. |
I now added a toggle to the settings for this: This is OFF by default. @z-huang let me know what you think and if this is fine code wise Btw. now that we have this toggle I could also try to add premium albums on search. |
Once you're logged in your account, you don't have pure privacy. Therefore, I think we can send cookies as long as the api needs login information to respond more information or unlock some features. What do you think? |
I think we should still try to find a balance here. For most users it is not necessary to send the login cookie with every request so we should not force them to. Especially with the recent changes now YTM forces users to log in, see issues like these: So I guess many users now log in only to avoid the playback issues.
I think this toggle is pretty cool and we should keep it. Besides privacy another nice thing I noticed while using it the last few days: So yeah, good to have the option. |
Btw I now send the cookie on all browse request if the option is enabled. Also changed the description to reflect that: @z-huang lmk if you have any more questions or feedback I should consider |
@z-huang I don't like to stress but unfortunately my premium runs out soon and I'm not sure yet if I will extend the subscription. If I can't get everything working that I need I might have to switch to a different streaming service and cancel premium for now. But this means I can't test anymore if anything comes up. Not sure what is going on in your life but it would be cool to know approximately when you can review this. If you need a longer time it will be okay, I only want to know. |
I understand your concern. This PR looks okay, so I'll merge it right away. Is there anything else you need? |
This change makes premium-exclusive albums visible on artist pages - given the user is logged in and has an active music premium subscription
Fixes #1630