Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player slider movement animation and text transitions #1349

Closed
wants to merge 2 commits into from

Conversation

nvllz
Copy link
Contributor

@nvllz nvllz commented Aug 11, 2024

1dbb8c98-7783-4870-9bd5-8a37765a603c.mp4

It looks much more natural than on the recording,

@z-huang
Copy link
Owner

z-huang commented Aug 11, 2024

I like the text animation, but not the slider movement. I want to know precise location when I drag the seek bar and don't want to wait for the dot to animate.

@z-huang
Copy link
Owner

z-huang commented Aug 11, 2024

If possible, transition for artwork will be great.

@nvllz
Copy link
Contributor Author

nvllz commented Aug 11, 2024

@z-huang this wasn't the case as I managed the drag gesture to not wait for the slider (no animation), but tapping "next song" caused the animation to glitch, which made me drop the slider movement feature. But I kept the timer transition and added a fade to the miniplayer, as shown below.

2bf69c16-434a-46f7-97f9-1396f56baa8a.mp4

As for the cover animation, I may try to implement it later in another PR, as it will require more work.

@z-huang
Copy link
Owner

z-huang commented Aug 12, 2024

I noticed a detail: the vertical position of texts may change if the two texts are of different size (e.g. English and Chinese). Can you fix it?

@nvllz
Copy link
Contributor Author

nvllz commented Aug 12, 2024

Can't do much about it, as it seems to be a compose bug.

@nvllz nvllz closed this Aug 13, 2024
@nvllz
Copy link
Contributor Author

nvllz commented Aug 14, 2024

Tomorrow I'll publish a more advanced PR with fixed animations for these labels containing certain characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants