Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist menu improvements #1174

Merged
merged 8 commits into from
Jan 21, 2024
Merged

Playlist menu improvements #1174

merged 8 commits into from
Jan 21, 2024

Conversation

nvllz
Copy link
Contributor

@nvllz nvllz commented Dec 18, 2023

A simple confirmation dialog before removing downloaded playlist.
Related to #1075

52560ee9-3d27-4445-a0cd-7b96eec2c1aa.mp4

@nvllz
Copy link
Contributor Author

nvllz commented Dec 19, 2023

Added a confirmation dialog before deleting a playlist.

@owencz1998
Copy link

Added a confirmation dialog before deleting a playlist.

By any chance can you also do one for adding the same song into a playlist so we get promoted that the current song already exsist in playlist this would be grate to.

Also nice work mate

@nvllz
Copy link
Contributor Author

nvllz commented Dec 30, 2023

Thank you.
Unfortunately, making an ok/cancel dialog in this case would require a little more work because of the way the thing is handled. It would be easier to implement an "Ok" only dialog that says the song is already in the playlist, but I don't know if the community would like it that way, so you can only have one instance of a song in a playlist.

@owencz1998
Copy link

No worries @nvllz thanks tho 😁

@nvllz nvllz changed the title Add a confirmation dialog in the playlist screen Playlist menu improvements Jan 5, 2024
@nvllz
Copy link
Contributor Author

nvllz commented Jan 5, 2024

I decided to put it here since this commit is somehow related to my recent work. I made a new version of PlaylistMenu that looks much better and matches other menus in the app. Also decided to put this little #1176 PR here. It's the biggest I've done so far, and I really wish this along my other pull requests would get merged one day.

095fe5c9-8ee0-487e-b608-e57a60c470cf.mp4

@z-huang z-huang merged commit 58c4e44 into z-huang:dev Jan 21, 2024
2 checks passed
@z-huang
Copy link
Owner

z-huang commented Jan 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants