Merge pull request #1462 from Malopieds/kill-service

Fix crash onDestroy when rotating
z-huang · Aug 27, 2024 · d921b0a · d921b0a
2 parents 0fd93da + e2f9800
commit d921b0a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/src/main/java/com/zionhuang/music/MainActivity.kt b/app/src/main/java/com/zionhuang/music/MainActivity.kt
@@ -189,7 +189,7 @@ class MainActivity : ComponentActivity() {
 
     override fun onDestroy() {
         super.onDestroy()
-        if (dataStore.get(StopMusicOnTaskClearKey, false) && playerConnection?.isPlaying?.value == true) {
+        if (dataStore.get(StopMusicOnTaskClearKey, false) && playerConnection?.isPlaying?.value == true && isFinishing) {
             stopService(Intent(this, MusicService::class.java))
             unbindService(serviceConnection)
             playerConnection = null