Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sign all request #95

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: Sign all request #95

wants to merge 1 commit into from

Conversation

yukimochi
Copy link
Owner

@yukimochi yukimochi commented Feb 24, 2024

related #94

  • Current GET Request sign is not interoperational.

@yukimochi yukimochi added the wontfix This will not be worked on label Feb 24, 2024
@yukimochi yukimochi self-assigned this Feb 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.78%. Comparing base (528e801) to head (e7fd53b).
Report is 6 commits behind head on master.

Files Patch % Lines
models/http_sign.go 73.33% 2 Missing and 2 partials ⚠️
models/models.go 0.00% 4 Missing ⚠️
api/decode.go 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   61.73%   61.78%   +0.05%     
==========================================
  Files          16       17       +1     
  Lines        1487     1489       +2     
==========================================
+ Hits          918      920       +2     
  Misses        516      516              
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants