Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all the required fields are populated in the html report for new flattened issues approach #2190

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

sanyamsinghal
Copy link
Collaborator

@sanyamsinghal sanyamsinghal commented Jan 16, 2025

Describe the changes in this pull request

This PR includes:

  • Having relevant value based on Issue field
  • Populating Description and Name in all query issues
  • Replacing AnalyzeSchemaIssue.Reason field to be equivalent QueryIssue.Description instead of QueryIssue.Name field
  • QueryIssue.Description will only contain dynamic information, rest all fields mostly will be static.
  • Fixed all the automation tests based on the new strings(reason/description etc)

Describe if there are any user-facing changes

nothing as such, only text has changed for some of the issue fields (reported in assess and analyze)

How was this pull request tested?

Fixing Existing tests to pass.

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB No
Name registry json No
Data File Descriptor Json No
Export Snapshot Status Json No
Import Data State No
Export Status Json No
Data .sql files of tables No
Export and import data queue No
Schema Dump No
AssessmentDB No
Sizing DB No
Migration Assessment Report Json No
Callhome Json No
YugabyteD Tables No
TargetDB Metadata Tables No

@sanyamsinghal sanyamsinghal self-assigned this Jan 16, 2025
@sanyamsinghal
Copy link
Collaborator Author

Jenkins Pipelines

  1. Running assessment related tests - https://jenkins.dev.yugabyte.com/job/users/job/yb-voyager-testing/job/yb-voyager-testing-pipeline/4477/

@sanyamsinghal sanyamsinghal marked this pull request as ready for review January 17, 2025 08:16
@sanyamsinghal sanyamsinghal requested review from priyanshi-yb and makalaaneesh and removed request for priyanshi-yb January 17, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant