Reporting range aggregate functions and IS JSON predicate clauses #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort-isjson-range-type
…ort-isjson-range-type
…umping views and mviews in >=PG16
…ort-isjson-range-type
priyanshi-yb
changed the title
…ort-isjson-range-type
| array_column TEXT CHECK (array_column IS JSON ARRAY), | ||
| scalar_column TEXT CHECK (scalar_column IS JSON SCALAR), | ||
| unique_keys_column TEXT CHECK (unique_keys_column IS JSON WITH UNIQUE KEYS) | ||
| ); |
There was a problem hiding this comment.
Should we add separate tables for each of the IS JSON clauses (not even each but at least 2 or three different clauses in different tables)? Currently the tables might just be getting reported due to the first IS JSON clause and the rest seem kind of useless.
| upper(range_agg(event_range)) AS latest_end | ||
| FROM | ||
| sales.events; |
There was a problem hiding this comment.
Same as above, currently the view has multiple unsupported functions. Better to split it into multiple views to ensure that all the function types are getting caught.
| scalar_column TEXT CHECK (scalar_column IS JSON SCALAR), | ||
| unique_keys_column TEXT CHECK (unique_keys_column IS JSON WITH UNIQUE KEYS) | ||
| ); |
There was a problem hiding this comment.
Same comment as above for this table too.
migtests/tests/pg/assessment-report-test-uqc/pg_assessment_report_uqc.sql
Show resolved
Hide resolved
sanyamsinghal
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
IS JSONpredicate clauses https://yugabyte.atlassian.net/browse/DB-14543range_agg,range_intersect_aggrange type functions - https://yugabyte.atlassian.net/browse/DB-14224Describe if there are any user-facing changes
Unsupported Feature
Unsupported Query Constructs -
Unsupported PL/pgSQL objects -
How was this pull request tested?
Does your PR have changes that can cause upgrade issues?