Remove guardrail check to allow users to increase the --batch-size parameter #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyanshi-yb
changed the title
| @@ -386,7 +387,7 @@ func validateBatchSizeFlag(numLinesInASplit int64) { | |||
| } | |||
|
|
|||
| if numLinesInASplit > defaultBatchSize { | |||
| utils.ErrExit("Error: Invalid batch size %v. The batch size cannot be greater than %v", numLinesInASplit, defaultBatchSize) | |||
| utils.PrintAndLog(color.YellowString("Increasing the --batch-size to a very high value is not recommended as the whole batch is executed in one transaction.")) | |||
There was a problem hiding this comment.
why was this restricted introduced in past?
There was a problem hiding this comment.
I also can't recall the exact reason, but AFAIK this was because not to let the user increase the batch-size beyond 20K, we do mention something along the lines here on perf page as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.