Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes when using public IPs #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug fixes when using public IPs #11

wants to merge 1 commit into from

Conversation

HarshDaryani896
Copy link
Collaborator

@HarshDaryani896 HarshDaryani896 commented Jan 2, 2025 •
edited
Loading

Following bugs are fixed as part of this PR:

  • If useHostColumn is False add public IPs in primaryNodes, rrNodes, hostToPriorityMapPrimary and hostToPriorityMapRR.
  • Correctly check if there are any primary or read-replica nodes in currentPublicIps.
  • if useHostColumn is not True, empty currentPublicIps to fallback to next fallback zones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashetkar ashetkar Awaiting requested review from ashetkar

@Sfurti-yb Sfurti-yb Awaiting requested review from Sfurti-yb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HarshDaryani896