Cherry pick PR #3086: [android] Fix low fps checking in video_decoder.cc #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mime attribute "framerate" is used to specify the frame rate of the video, and the previous implementation incorrectly used "fps" as the mime attribute name. b/286121490 Change-Id: Iaec70f33ab625224e8a31eba96db0bea063f0a8a (cherry picked from commit fac2625)
xiaomings
approved these changes
Apr 29, 2024
kaidokert
pushed a commit
that referenced
this pull request
Sep 21, 2024
[PR 3103](#3103) fixed MIME attribute "framerate" that enforces `a low resolution and low fps playback` to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Oct 7, 2024
This is the same PR as youtube#4111. Original commit message: [PR 3103](youtube#3103) fixed MIME attribute "framerate" that enforces a low resolution and low fps playback to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Oct 7, 2024
This is the same PR as youtube#4111. Original commit message: [PR 3103](youtube#3103) fixed MIME attribute "framerate" that enforces a low resolution and low fps playback to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Oct 17, 2024
This is the same PR as youtube#4111. Original commit message: [PR 3103](youtube#3103) fixed MIME attribute "framerate" that enforces a low resolution and low fps playback to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Oct 21, 2024
This is the same PR as youtube#4111. Original commit message: [PR 3103](youtube#3103) fixed MIME attribute "framerate" that enforces a low resolution and low fps playback to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Oct 24, 2024
This is the same PR as youtube#4111. Original commit message: [PR 3103](youtube#3103) fixed MIME attribute "framerate" that enforces a low resolution and low fps playback to use software video decoder. However, If software video decoder is not available, Cobalt should fallback to hardware video decoder. b/328537630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3086
The mime attribute "framerate" is used to specify the frame rate of the video, and the previous implementation incorrectly used "fps" as the mime attribute name.
b/286121490
Change-Id: Iaec70f33ab625224e8a31eba96db0bea063f0a8a