Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnackBar 구현 #14

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

SnackBar 구현 #14

wants to merge 27 commits into from

Conversation

leeeyubin
Copy link
Member

@leeeyubin leeeyubin commented Sep 23, 2024 •
edited
Loading

SnackBar 구현했습니다.

  • 스낵바 올라오고, 내려가는 애니메이션 구현
  • 정보성 스낵바 5초 후, 자동으로 사라지는 기능
  • 정보성 스낵바 아래로 스와이프 시, 사라지는 기능
  • 에러 스낵바 엑스 아이콘 클릭 시, 사라지는 기능
  • 두 줄 넘어갈 시, 단어 단위의 개행
image
기본 기능 스와이프 기능
Screen_Recording_20241031_110536_Handy-Android.mp4
drag.mp4

@leeeyubin leeeyubin added the enhancement New feature or request label Sep 23, 2024
@leeeyubin leeeyubin self-assigned this Sep 23, 2024
kangyuri1114
kangyuri1114 reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@kangyuri1114 kangyuri1114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 수정사항이 있어서 확인 부탁드려요!

compose/src/main/kotlin/com/yourssu/handy/compose/SnackBar.kt Outdated Show resolved Hide resolved
compose/src/main/kotlin/com/yourssu/handy/compose/SnackBar.kt Outdated Show resolved Hide resolved
compose/src/main/kotlin/com/yourssu/handy/compose/SnackBar.kt Show resolved Hide resolved
compose/src/main/kotlin/com/yourssu/handy/compose/SnackBar.kt Show resolved Hide resolved
compose/src/main/res/drawable/ic_alert_triangle.xml Outdated Show resolved Hide resolved
kangyuri1114
kangyuri1114 approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@kangyuri1114 kangyuri1114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

HI-JIN2
HI-JIN2 reviewed Jan 13, 2025
View reviewed changes
app/src/main/kotlin/com/yourssu/handy/demo/SnackBarPreview.kt
Spacer(modifier = Modifier.height(10.dp))
ErrorSnackBar(
text = "두 줄 이상의 에러 메세지가 들어갈 경우 아이콘은 모두 위로 정렬해주세요.",
onClick = {}
Copy link
Member

@HI-JIN2 HI-JIN2 Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X 버튼 클릭이라는게 좀더 잘 드러나면 어떨까요? onCancel(Click) 이나 onClose(Click) 등.. X 버튼 클릭의 부정적인 느낌이 좀 더 나면 좋을 것 같습니도

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HI-JIN2 HI-JIN2 HI-JIN2 left review comments

@kangyuri1114 kangyuri1114 kangyuri1114 approved these changes

Assignees

@leeeyubin leeeyubin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leeeyubin @kangyuri1114 @HI-JIN2