Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lilseyi/separate context #351

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lilseyi
Copy link

@lilseyi lilseyi commented Oct 16, 2024

Description

Add support for separating the context from the YooptaEditor, this allows users to lift the context up from the editor, and access editor state from other sibling components.

// Still Supported
import { YooptaEditor } from '@yoopta/editor'

// New Alternative
import { YooptaEditorProvider, Editor } from '@yoopta/editor'

Fixes # (issue)

Type of change

Please tick the relevant option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Copy link

vercel bot commented Oct 16, 2024

@lilseyi is attempting to deploy a commit to the dargo's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Darginec05
Copy link
Collaborator

Hey @lilseyi, sorry for delay.
I need to merge this PR before, because PR includes many changes for Core operations and root <YooptaEditor /> component.
So, after the merging, I'll take a look and see the best solution that can be with the new architecture

@lilseyi
Copy link
Author

lilseyi commented Oct 24, 2024

No worries @Darginec05 , Excited for the new changes, any idea on when your PR will be merged?

@Darginec05
Copy link
Collaborator

No worries @Darginec05 , Excited for the new changes, any idea on when your PR will be merged?

I hope it will be released tomorrow 👀

@lilseyi
Copy link
Author

lilseyi commented Nov 9, 2024

@Darginec05 I've merged this PR with all the new changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants