replaces bubblegum's bloody knuckles loot with philosopher's tome #20578

LazennG · 2023-10-09T03:05:50Z

Document the changes in your pull request

Replaces the bloody knuckles drop with a new item called philosopher's tome, which can

parry to deflect damage
cause "explosions" to mine
grant ore from killing most enemies
do a few animations

The book starts off with 3 parry charges, that each recharge after 10 seconds. They can be used to activate a shield that immobilizes the user for one second and lasts for half a second. If damage is taken while the shield is up, it's undone when it goes down and the user gets a bonus parry charge along with being healed for 5 brute and burn and whatever brute/burn/stamina damage they took in that time. Whatever damage they took while shielded is redirected towards the nearest target as brute damage, with damage to nonanimals capping at 20. Targets within melee range are shoved away from the user a la disarm.

When inflicting damage, nonanimals by default take 10 brute with 10ap, while animals take 40. When the damage dealt makes the target cross the 60%, 30%, and 0% thresholds, an "explosion" happens, dealing a tenth of the target's max hp to non-user mobs within a range determined by the target's (maxhp/150)+1, with rocks within this range being mined too. This damage can cause chain reactions. Additionally, if the damage is done with a direct melee attack from the book, an animation will play. Damaging targets at the 30% and 60% thresholds will apply twice the usual damage.

While parrying, the user is unable to drop the book, go into crit, and will leave most crowd control effects placed on them after the shield expires in addition to extinguishing themself. To mitigate free parries, they won't care about pressure damage or temperature damage for the half second the shield is active.

https://cdn.discordapp.com/attachments/987151374007537714/1160534002634068030/dreamseeker_XojdrATr6f.gif?ex=65350283&is=65228d83&hm=3b5d7044dff9be244fa925579333a24614a6cd5d535146fee81b63cb629911bc&

If the target is catatonic or an animal and reaches 0 hp, they gib when killed and drop a few sheets of an ore (iron, gold, uranium, titanium, silver, diamond, bluespace, glass, or plasma). Otherwise if it's a player they just go into crit and can't be gibbed with this.

oh also i changed the goat king code a bit so it dropping loot was more straightforward and added a new sound for one of the finishers

bubbleblender.mp4

Why is this good for the game?

I regret bloody knuckles because in hindsight they're essentially a forcestick with a weak gimmick attached that doesn't offer any interesting new way to play miner and I believe this does.

Testing

Don't wanna spoil them by posting them all here but i made sure all the animations work along with making sure loot drops correctly and that fauna resume their behavior after the animations.

Spriting

sprites for the new book

Wiki Documentation

https://wiki.yogstation.net/wiki/Megafauna#Loot_3
Replacing the bloody knuckles line with something like
"Philosopher's tome, a book that can parry incoming attacks and mine rocks near targets that take enough damage."

Changelog

🆑
rscadd: Added philospher's tome loot
rscdel: Removed bloody knuckles from bg loot
tweak: tweaked the way goat king drops its loot
soundadd: added bubbleblender.ogg
imageadd: added sprites for philospher's tome
/:cl:
huge thanks to @thegoldencat413 for testing, feedback, and spriting of the item. additionally, thanks to @Chubbygummibear for code help, and thanks to @solwashere for helping me figure out what i wanted the item to be thematically

cowbot92 · 2023-10-09T03:26:18Z

who let this man COOK

Moltijoe · 2023-10-09T03:36:12Z

god bless that fuckin portal execute

Mqiib · 2023-10-09T03:47:47Z

What's this??? Interesting and unique items from mining that aren't just reskinned eswords????

LazennG · 2023-10-11T02:21:32Z

just learned what easing was so gonna be redoing the animations while trying to use those instead

… I'M GONNA FUCKING KILL MYSELF

Moltijoe

Code is a nightmare to look at, but i realize you're doing something that byond isn't designed for

yogstation/code/modules/mining/lavaland/bloodbook.dm

Moltijoe · 2023-10-17T00:33:12Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+	var/turf/front = get_step(L.loc, (src.dir))
+	if(ismineralturf(front))
+		var/turf/closed/mineral/M = front
+		M.attempt_drill()


what happens if attempt_drill doesn't work for whatever reason?

double checked and it stops wherever it currently is and returns false, ending the animation

replaced phase++ with phase+1 in addtimers var/phase into just phase added returns also fixed animating people past crit

found the thing that makes people ash storm resistant so no farming a billion charges in one storm

LazennG · 2023-10-21T03:31:58Z

bubbleblender.mp4

head dev found the guilty gear strive audio so this is no longer in the pr, it's so zatover bros

Moltijoe

animation code makes me want to vomit, but it looks fine and you've shown it functions
i look forward to the bugfix prs

JohnFulpWillard · 2023-10-30T14:16:00Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+	if(blocks == 0)
+		icon_state = "grimoireempty"


This should be on update_icon_state

JohnFulpWillard · 2023-10-30T14:16:18Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+		inflict(thrownby, M, 0, FALSE)
+
+/obj/item/bloodbook/proc/tenderize(mob/living/user, mob/living/target, var/damage = 10)
+	var/obj/item/bodypart/limb_to_hit = target.get_bodypart(user.zone_selected)


You're not checking if they have said limb, it will cause runtimes

JohnFulpWillard · 2023-10-30T14:16:26Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+	var/armor = target.run_armor_check(limb_to_hit, MELEE, armour_penetration = 10)
+	target.apply_damage(damage, BRUTE, limb_to_hit, armor, wound_bonus=CANT_WOUND)
+
+/obj/item/bloodbook/proc/sceneend(mob/living/target, mob/living/user, var/die = FALSE)


no vars in args

JohnFulpWillard · 2023-10-30T14:16:30Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+		var/mob/living/M = hit_atom
+		inflict(thrownby, M, 0, FALSE)
+
+/obj/item/bloodbook/proc/tenderize(mob/living/user, mob/living/target, var/damage = 10)


no vars in args. there's more than just here so replace it everywhere else too.

JohnFulpWillard · 2023-10-30T14:17:01Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+	var/normaldam = 10
+	var/otherwisedam = 40
+	COOLDOWN_DECLARE(last_bigfinish)
+	var/list/orelist = list(/obj/item/stack/ore/iron, /obj/item/stack/ore/uranium, /obj/item/stack/ore/gold, /obj/item/stack/ore/silver, /obj/item/stack/ore/diamond, /obj/item/stack/ore/bluespace_crystal, /obj/item/stack/ore/glass, /obj/item/stack/ore/plasma, /obj/item/stack/ore/titanium)


This can be a static list and it should be multiline

JohnFulpWillard · 2023-10-30T14:18:13Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+	for(L in view(9, user))
+		if(L != user)
+			log_combat(user, L, "directed a counter towards", src)
+			to_chat(user, span_warning("[user] redirects incoming damage towards [L]!"))
+			to_chat(L, span_userdanger("[user] shifts their damage onto you!"))
+			inflict(user, L, retaliatedam, FALSE)
+			return


This is supposed to just damage a single random person within a 9 tile radius?

JohnFulpWillard · 2023-10-30T14:18:36Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+	if(blocks < 1)
+		icon_state = "grimoire"
+	blocks++
+	return


Don't need a return at the end of a proc

JohnFulpWillard · 2023-10-30T14:19:36Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+		target.color = "#ff0000"
+		target.alpha = 100
+
+/obj/item/bloodbook/proc/shatter(mob/living/simple_animal/target)


your new thing(loc) should use drop_location()

JohnFulpWillard · 2023-10-30T14:20:00Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+
+/obj/item/bloodbook/proc/tantrum(mob/living/user, mob/living/target, phase = 1, obj/hand, list/slamming)
+	switch(phase)
+		if(1)


These float numbers should be defines that you will undefine after this proc, same for the ones under.

JohnFulpWillard · 2023-10-30T14:20:10Z

yogstation/code/modules/mining/lavaland/bloodbook.dm

+	switch(phase)
+		if(1)
+			var/list/wrecking = list()
+			var/obj/structure/prop/killhand/B = new(target.loc)


remove single-letter var please

JohnFulpWillard · 2023-10-30T14:21:59Z

a little late on the review sorry bros 🥲

LazennG added 14 commits July 14, 2023 16:38

gotta edit seismic brb a sec

c9d91a2

brb a sec

6d8a448

pausing

a512abe

6

4983fce

animation epiphany

1e07ee9

Merge remote-tracking branch 'upstream/master' into midas-gauntlet

f43eb34

rebrand

512eaf7

noise

74fe044

replacement

566b831

Merge remote-tracking branch 'upstream/master' into midas-gauntlet

a08a0c1

boom reduction

4a992d1

100

fc02c29

Update bloodbook.dm

9155f9c

Update bloodbook.dm

0de82b2

LazennG requested review from a team as code owners October 9, 2023 03:05

Yogbot-13 added DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Revert / Deletion Altoids is probably mad about this Sprites This PR has spriting changes Tweak This PR contains changes to the game. labels Oct 9, 2023

github-actions bot added the Sound This PR changes audio files label Oct 9, 2023

maybe?

3950685

Moltijoe added the Awaiting - Action - Balance Review Code Director Review label Oct 9, 2023

LazennG added 3 commits October 8, 2023 21:55

workin?

12b380d

maybe

e375c05

YEP I'M THINKING WE'RE SO BACK

e4c0e75

LazennG added 2 commits October 9, 2023 23:22

VORTEX

1f48f3c

sfx

4f2e899

LazennG marked this pull request as draft October 11, 2023 02:21

cuackles approved these changes Oct 11, 2023

View reviewed changes

LazennG added 3 commits October 12, 2023 03:00

FUCKING EASING AFTER DOING ALL THAT SHIT I DISCOVER IT AFTER THE FACT…

75bfb1e

… I'M GONNA FUCKING KILL MYSELF

Update bloodbook.dm

e7b171e

grilled cheese sounds good right now

9f2f5fb

LazennG marked this pull request as ready for review October 14, 2023 06:06

LazennG added 4 commits October 14, 2023 15:17

called it red oops

6bcc4bb

Update bloodbook.dm

456c5df

no leaving the stage

8ee1951

lowering dunk immobilize time a sec

8ceff82

Moltijoe requested changes Oct 17, 2023

View reviewed changes

molti changes

32a60a1

replaced phase++ with phase+1 in addtimers var/phase into just phase added returns also fixed animating people past crit

LazennG requested a review from Moltijoe October 17, 2023 07:57

NIPPED A POSSIBLE EXPLOIT LAST MINUTE

504ef3a

found the thing that makes people ash storm resistant so no farming a billion charges in one storm

MajManatee added Awaiting - Action - HD Awaiting action from Jamie Awaiting - Action - Balance Review Code Director Review and removed Awaiting - Action - Balance Review Code Director Review labels Oct 17, 2023

LazennG added 3 commits October 17, 2023 15:56

sfx for when a parry is successful

fa54569

mom found the unoriginal sound drawer

a59d84e

Update bloodbook.dm

524c191

Moltijoe approved these changes Oct 22, 2023

View reviewed changes

ToasterBiome approved these changes Oct 22, 2023

View reviewed changes

ToasterBiome merged commit 41bdbc7 into yogstation13:master Oct 22, 2023
5 checks passed

Yogbot-13 added a commit that referenced this pull request Oct 22, 2023

Automatic changelog generation #20578 [ci skip]

49bf8ba

JohnFulpWillard reviewed Oct 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replaces bubblegum's bloody knuckles loot with philosopher's tome #20578

replaces bubblegum's bloody knuckles loot with philosopher's tome #20578

LazennG commented Oct 9, 2023

cowbot92 commented Oct 9, 2023

Moltijoe commented Oct 9, 2023

Mqiib commented Oct 9, 2023

LazennG commented Oct 11, 2023

Moltijoe left a comment

Moltijoe Oct 17, 2023

LazennG Oct 17, 2023

LazennG commented Oct 21, 2023

Moltijoe left a comment

JohnFulpWillard Oct 30, 2023

JohnFulpWillard Oct 30, 2023

JohnFulpWillard Oct 30, 2023

JohnFulpWillard Oct 30, 2023

JohnFulpWillard Oct 30, 2023

JohnFulpWillard Oct 30, 2023

JohnFulpWillard Oct 30, 2023

JohnFulpWillard Oct 30, 2023

JohnFulpWillard Oct 30, 2023

JohnFulpWillard Oct 30, 2023

JohnFulpWillard commented Oct 30, 2023

replaces bubblegum's bloody knuckles loot with philosopher's tome #20578

replaces bubblegum's bloody knuckles loot with philosopher's tome #20578

Conversation

LazennG commented Oct 9, 2023

Document the changes in your pull request

Why is this good for the game?

Testing

Spriting

Wiki Documentation

Changelog

cowbot92 commented Oct 9, 2023

Moltijoe commented Oct 9, 2023

Mqiib commented Oct 9, 2023

LazennG commented Oct 11, 2023

Moltijoe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LazennG commented Oct 21, 2023

Moltijoe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JohnFulpWillard commented Oct 30, 2023