Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use ANDROID_ADB_SERVER_PORT optionally #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lib: use ANDROID_ADB_SERVER_PORT optionally #6

wants to merge 1 commit into from

Conversation

xqbumu
Copy link

@xqbumu xqbumu commented Feb 14, 2019

Add gengrateADBClient in lib/common.ts to enable use env variable ANDROID_ADB_SERVER_PORT.

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added

@yorkie yorkie requested a review from legendecas February 15, 2019 04:33
@legendecas
Copy link
Contributor

Thank you for your swift proposing of PR 👍. It looks awesome to me.

But since package yoda-platform-lib is designed to be embedded into other tools like yoda-cli and yoda-vscode, I'd suggest exposing options of adb.createClient with PlatformSelector/PlatformClient constructor parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas Awaiting requested review from legendecas

Assignees
No one assigned
Labels
yoda-platform-lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xqbumu @legendecas