Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use host locale setting instead of static 'en' locale as default #241

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

yobacca
Copy link
Owner

@yobacca yobacca commented Nov 18, 2024

If no explicit locale has been provided to compare() or orderBy() there should be the locale setting of the host be acknowledged.

@yobacca yobacca self-assigned this Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (f04cd40) to head (b3d4b13).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   98.70%   98.69%   -0.01%     
==========================================
  Files          34       34              
  Lines         308      307       -1     
  Branches      102      101       -1     
==========================================
- Hits          304      303       -1     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yobacca yobacca merged commit f62ca6f into main Nov 18, 2024
12 checks passed
@yobacca yobacca deleted the use-host-locale-as-default branch November 18, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants