Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CompositeAuth auth methods to use their own request and respon… #20313

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mtangoo
Copy link
Contributor

@mtangoo mtangoo commented Jan 16, 2025

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #20238

@mtangoo mtangoo requested a review from a team January 16, 2025 22:14
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.84%. Comparing base (a05f60b) to head (c8d8951).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
framework/filters/auth/CompositeAuth.php 60.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20313      +/-   ##
============================================
- Coverage     64.84%   64.84%   -0.01%     
- Complexity    11427    11433       +6     
============================================
  Files           431      431              
  Lines         37177    37187      +10     
============================================
+ Hits          24109    24115       +6     
- Misses        13068    13072       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark merged commit d146307 into yiisoft:master Jan 17, 2025
86 of 87 checks passed
@samdark
Copy link
Member

samdark commented Jan 17, 2025

👍

@samdark samdark added this to the 2.0.52 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants