Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use self to access private method in BaseFormatConverter #20018

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Use self to access private method in BaseFormatConverter #20018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions framework/helpers/BaseFormatConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
{
if (isset(self::$_icuShortFormats[$pattern])) {
if (extension_loaded('intl')) {
$pattern = static::createFormatter($locale, $type, $pattern);
$pattern = self::createFormatter($locale, $type, $pattern);

Check warning on line 106 in framework/helpers/BaseFormatConverter.php

View check run for this annotation

Codecov / codecov/patch

framework/helpers/BaseFormatConverter.php#L106 

Added line #L106 was not covered by tests
} else {
return static::$phpFallbackDatePatterns[$pattern][$type];
}
Expand Down Expand Up @@ -347,7 +347,7 @@
{
if (isset(self::$_icuShortFormats[$pattern])) {
if (extension_loaded('intl')) {
$pattern = static::createFormatter($locale, $type, $pattern);
$pattern = self::createFormatter($locale, $type, $pattern);

Check warning on line 350 in framework/helpers/BaseFormatConverter.php

View check run for this annotation

Codecov / codecov/patch

framework/helpers/BaseFormatConverter.php#L350 

Added line #L350 was not covered by tests
} else {
return static::$juiFallbackDatePatterns[$pattern][$type];
}
Expand Down
Loading