Fix #80: Added a check on current server's php.ini's 'max_execution_time' requiring it to exceed the time specified / tested application's comfortable installation time #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
============================================
- Coverage 15.48% 13.30% -2.18%
- Complexity 57 60 +3
============================================
Files 4 4
Lines 452 526 +74
============================================
Hits 70 70
- Misses 382 456 +74 ☔ View full report in Codecov by Sentry. |
samdark
requested changes
Nov 11, 2024
| * @param string|null $max | ||
| * @return bool | ||
| */ | ||
| public function checkMaxExecutionTime(?string $max = null): bool |
There was a problem hiding this comment.
Just following the above function checkUploadMaxFileSize which uses strings for min and max. Yes should be int.
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
samdark
approved these changes
Nov 13, 2024
|
All good. Please add a line for CHANGELOG. |
samdark
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a useful check prior to installation preventing unnecessary installation timeouts.