enhanced feature controls #1208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacobryas4
commented
May 24, 2023
jacobryas4
commented
- enhanced feature controls in settings so we can disable certain features in the UI
- new UI component to cover controls to prevent user input
- modified useAllowAction hook to take new feature controls into consideration
✅ Deploy Preview for yield-v2-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
brucedonovan
approved these changes
Jun 1, 2023
| @@ -258,3 +259,31 @@ export const numberWithCommas = (x: number) => x.toString().replace(/\B(?=(\d{3} | |||
|
|
|||
| export const formatValue = (x: string | number, decimals: number) => | |||
| numberWithCommas(Number(cleanValue(x?.toString(), decimals))); | |||
|
|
|||
There was a problem hiding this comment.
This all looks good. The only thing I would suggest is moving this actionControlMapping into the 'useAllowAction' hook directly. - certainly not essential, but it is pretty specific to that hook ... and will keep all concerns together.
(just FYI: Although obviously now some Yield specific functions have crept into this file, This appUtils originally started out a 'general tools' store shared for any app. - better naming is probably required. :) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.